added ability to specify request options via config #40
Conversation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
this allows the consumer to supply additional options to the http.get request call by doing
The longer story is, i'm using the module from within a chrome extension. That extension sometimes makes mixpanel calls from a window whose protocol is
chrome-extension://. Since no scheme is specified,httpuses the document's scheme, so the request ends up beingchrome-extension://api.mixpanel.com.... fail.Updated tests, everything still pases.
zeev