Skip to content

Here's what's popular on GitHub today...

Game Off Highlights
Game Bytes

The theme for this year’s Game Off was ‘moonshot’ and the entries were out of this world! Fork and play some of the top-rated games.

Kubernetes logo
Popular topic
Kubernetes is an open source system for automating deployment, scaling, and management of containerized applications.
superset
Trending repository
App recommended by GitHub

Pull Assistant

Every time you create a pull request, Pull Assistant analyses it and provides you all necessary information to perform code reviews faster and with confidence.

Trending repository
BasixKOR
BasixKOR commented Jan 6, 2021

While working on Korean translation I noticed errorSplash strings are based on concateration approach, which may not work in all languages due to the differences in ordering of words.

I suggest using string interpolation instead of concatenating a variable between pre and post strings.

References

[How to concatenate localized strings mindfully by Shopify](https://ux.shopify.com/how-

Trending repository
ogrisel
ogrisel commented Nov 13, 2020

Most functions in scipy.linalg functions (e.g. svd, qr, eig, eigh, pinv, pinv2 ...) have a default kwarg check_finite=True that we typically leave to the default value in scikit-learn.

As we already validate the input data for most estimators in scikit-learn, this check is redundant and can cause significant overhead, especially at predict / transform time. We should probably a

Trending repository
JeanGolang
JeanGolang commented Feb 7, 2017

Hello Philip!
I think there is an issue with this part of the code of rqlite (store/store.go).

func (s *Store) Database(leader bool) ([]byte, error) {
	if leader && s.raft.State() != raft.Leader {
		return nil, ErrNotLeader
	}
	// Ensure only one snapshot can take place at once, and block all queries.
	s.mu.Lock()
	defer s.mu.Unlock()

	f, err := ioutil.TempFile("", "rqlilte-snap-
Trending repository
nielsvanvelzen
nielsvanvelzen commented Dec 8, 2020

Describe the bug

The current implementation of the authorization header parsing has (at least) the following issues:

  • A value can't contain any commas
  • A value can't start or end with a doublequote
  • A value can't contain special characters
    • HTTP Headers only allow ASCII characters
    • There is no option to encode/decode the values (using base64 or urlencoding)
  • When a value c
DeepSource screenshot
App recommended by GitHub

DeepSource

DeepSource helps you find and fix issues during code reviews.

Seamless integration with GitHub lets you start analyzing code in a couple of minutes. Follow our documentation and guides to get started — deepsource.io/docs/