Deprecate old test script commands #19893
Conversation
| "test-build-devtools": "yarn test --build --project devtools", | ||
| "debug-test-build-devtools": "yarn test --debug --build --project devtools", | ||
| "debug-test-build-devtools": "yarn test --deprecated 'yarn test-build-devtools --debug'", |
rickhanlonii
Sep 23, 2020
Author
Member
In the end we'll have three base test commands:
- test
- test-www
- test-build-devtools
In the end we'll have three base test commands:
- test
- test-www
- test-build-devtools
rickhanlonii
Sep 23, 2020
Author
Member
Well, we already only have three commands since the aliases proxy to them.
Well, we already only have three commands since the aliases proxy to them.
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 5229225:
|
|
Do we reference the old commands anywhere in the docs or PR template? |
|
Please update the CI command names. They should represent the command you have to run to repro the test failure. Although not sure how you’d tell someone to put a double dash. |
|
Tbh this is a lot less discoverable (if we actually remove them). I always go to package JSON files in projects to find all the commands I might need to run. Where is a single list of commands I need to run now? |
|
Note that the only thing that's really changing between the aliases and the new commands is that -- So instead of This also means you can easily test missing permutations. For example, we don't have a For a list of all supported options, we have the help message:
Does this help @sebmarkbage? |
|
Update: I added
I've also updated the circle test names to reflect the command that you would run to repro. I think we should give this a try and if we hate it we can re-evaluate. |
rickhanlonii
merged commit 8805873
into
facebook:master
Overview
These aliases have been replaced with the easier to use arguments like
--debugand--prodand the aliases have been proxing to the new commands for awhile now.Deprecating the aliases now to give people a chance to use the new commands directly before removing them later.