Improve tiering disablement for `UnmanagedCallersOnly` methods #46710
+70
−90
Conversation
- Simplifies #46550 and fixes some issues - Disables call counting and adjusts the tier appropriately for `UnmanagedCallersOnly` methods - Fixes optimization flags sent to the JIT for the default code version when call counting is disabled, including when an `UnmanagedCallersOnly` method is attributed with `AggressiveOptimization`. On the default code version path previously it wasn't checking if call counting was disabled, and since that's an expensive check to add on that path, added a flag to `PrepareCodeConfig`. - Fixes some miscellaneous inconsistencies between call counting enablement, optimization tier, and jit flags
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
UnmanagedCallersOnlymethodsUnmanagedCallersOnlymethod is attributed withAggressiveOptimization. On the default code version path previously it wasn't checking if call counting was disabled, and since that's an expensive check to add on that path, added a flag toPrepareCodeConfig.