Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite ARM64 IJW bootstrap thunk assembly. #46933

Open
wants to merge 1 commit into
base: master
from

Conversation

@jkoritzinsky
Copy link
Member

@jkoritzinsky jkoritzinsky commented Jan 13, 2021

Rewrite the inline assembly used in the ARM64 IJW bootstrapping thunks.

The original assembly here was a copy of the ARM32 thunks as the original source of this code had a copy-paste bug.

This PR enables native code to call into a C++/CLI assembly via a native export on ARM64 (this scenario before was completely broken).

The fix has been validated offline by the people who reported the issue.

Fixes #46894

@msftbot
Copy link
Contributor

@msftbot msftbot bot commented Jan 13, 2021

Tagging subscribers to this area: @vitek-karas, @agocke
See info in area-owners.md if you want to be subscribed.

Issue Details

Rewrite the inline assembly used in the ARM64 IJW bootstrapping thunks.

The original assembly here was a copy of the ARM32 thunks as the original source of this code had a copy-paste bug.

This PR enables native code to call into a C++/CLI assembly via a native export on ARM64 (this scenario before was completely broken).

The fix has been validated offline by the people who reported the issue.

Fixes #46894

Author: jkoritzinsky
Assignees: -
Labels:

arch-arm64, area-Host, os-windows

Milestone: 6.0.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

1 participant
You can’t perform that action at this time.