Skip to content

/ runtime

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix the GenericTest.Vector*Boolean #47070

Open
wants to merge 1 commit into
base: master
from
Open

Fix the GenericTest.Vector*Boolean #47070

wants to merge 1 commit into from
+15 −15

Conversation

@sandreenko
Copy link
Member

@sandreenko sandreenko commented Jan 16, 2021

Bool need special marshaling attribute, the test was failing on arm64 apple
where C++ was expecting them to be packed as 1 byte.

Thanks, @jkoritzinsky for helping with this.
@sandreenko
Fix the GenericTest.Vector*Boolean
Loading status checks…
85f4844 
Bool need special marshalling attribute, the test was failing on arm64 apple
where C++ was expecting them to be packed as 1 byte.
@dotnet-issue-labeler
Copy link

@dotnet-issue-labeler dotnet-issue-labeler bot commented Jan 16, 2021

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.
@sandreenko
Copy link
Member Author

@sandreenko sandreenko commented Jan 16, 2021

cc @sdmaclea, @janvorli , @mangod9
@jkoritzinsky
jkoritzinsky approved these changes Jan 16, 2021
View changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkoritzinsky jkoritzinsky

@tannergooding tannergooding

Assignees
No one assigned
Labels
arch-arm64 area-Interop-coreclr os-ios test bug
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@sandreenko @jkoritzinsky
You can’t perform that action at this time.