Add leveled logging #1249
Merged
Add leveled logging #1249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vardhanapoorv
requested review from
ashish-goswami,
jarifibrahim,
manishrjain and
as code owners
jarifibrahim
approved these changes
Mar 21, 2020
Please update the PR description to explain why this change is necessary.
Reviewable status: 0 of 2 files reviewed, 1 unresolved discussion (waiting on @ashish-goswami, @jarifibrahim, @manishrjain, and @vardhanapoorv)
options.go, line 214 at r1 (raw file):
// // The default value of LoggingLevel is INFO. func (opt Options) WithLoggingLevel(val int) Options {
Having a new type LoggingLevel would help the users to set the level easily. When a user is looking at this API, they wouldn't know what is the int value for DEBUG.
manishrjain
approved these changes
Apr 6, 2020
Reviewed 2 of 2 files at r1.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @ashish-goswami and @vardhanapoorv)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Adding leveled logging in Badger.
This change is