-
Notifications
You must be signed in to change notification settings - Fork 4.1k
feat(firebase_ml_vision): Add rawBytes to the Barcode class (#1816) #2368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(firebase_ml_vision): Add rawBytes to the Barcode class (#1816) #2368
Conversation
|
Hey @bparrishMines :) Just wanted to find out - do you believe this PR will go in in the short term, or will it still be a while due to the breaking change? Reason for my asking is that a few people have asked me about which scanner they can use to get the raw bytes from a barcode so it seems like a pressing issue - I've directed them all to leave a 👍 on the linked issue - #1816 - but was thinking that if it is still going to be a while before this PR goes in, then I may release a separate plugin in the interim. Thanks in advance for any feedback 🙂 |
|
Hi @marcus-bornman, thanks for the contribution. Unfortunately we don't have anyone that can work on adding and maintaining new features for this plugin. We do have people working on making ML Kit feature complete, but I can't give you a time frame for when this will be finished yet. We do work on issues based on the number of thumbs though, so keeping the issue will help get the feature prioritized. |
…-bytes-for-barcodes # Conflicts: # AUTHORS # README.md # packages/firebase_ml_vision/CHANGELOG.md # packages/firebase_ml_vision/README.md # packages/firebase_ml_vision/pubspec.yaml
|
Pulled latest changes from master |
|
cc @Salakar |
|
News? |
|
Any update? |
|
News? |
|
Why is this titled as Should this be |
|
Also could you fix the conflicts on the test file? (reverting the changelog/pubspec should fix those conflicts) |
| /// Barcode bytes as they were encoded in the barcode. | ||
| /// | ||
| /// Null if nothing found. | ||
| final Uint8List rawBytes; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not really fond of having the native side transmit the bytes list without the client requesting for it.
That'll make the communication slower for everyone, even those who aren't using rawBytes.
Thoughts @Salakar?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Salakar @rrousselGit Any more insight into this? :) How would you prefer to go about this alternatively?
…-bytes-for-barcodes
Made the change :) The PR was originally a breaking change but after more recent changes it is no longer one - just forgot to update the title. |
Done :) |
|
@rrousselGit Updated the PR based on your comments - mind taking a look again? :-) |
|
@rrousselGit @Salakar Hey guys :) Any update on this? |
|
This seems alright to me. |
Add nullable to rawBytes
|
Hey @marcus-bornman 👋 - appreciate this PR however unfortunately the I'd recommend switching to the alternatives now;
Apologies for any inconvenience here and best of luck switching over the the new APIs. Thanks |
|
Since the |
Description
firebase-ml-vision-image-label-modelandfirebase-ml-vision-face-modelandroid dependencies to19.0.0to accommodate the aforementioned upgrade of firebase-ml-vision.rawBytesto theBarcodeclass. Populated this withgetRawBytesfor android and withrawDatafor iOSRelated Issues
Checklist
Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes (
[x]). This will ensure a smooth and quick review process.///).flutter analyze) does not report any problems on my PR.Breaking Change
Does your PR require plugin users to manually update their apps to accommodate your change?