Skip to content

Conversation

@the-mars-rover
Copy link

@the-mars-rover the-mars-rover commented Apr 15, 2020

Description

  • In the example, upgraded the firebase-ml-vision-image-label-model and firebase-ml-vision-face-model android dependencies to 19.0.0 to accommodate the aforementioned upgrade of firebase-ml-vision.
  • Added rawBytes to the Barcode class. Populated this with getRawBytes for android and with rawData for iOS

Related Issues

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]). This will ensure a smooth and quick review process.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • If the pull request affects only one plugin, the PR title starts with the name of the plugin in brackets (e.g. [cloud_firestore])
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (flutter analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy.
  • I updated CHANGELOG.md to add a description of the change.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate a breaking change in CHANGELOG.md and increment major revision).
  • No, this is not a breaking change.

@the-mars-rover the-mars-rover changed the title Ml vision add raw bytes for barcodes [firebase_ml_vision] Add rawBytes to the Barcode class (#1816) Apr 15, 2020
@the-mars-rover
Copy link
Author

Hey @bparrishMines :)

Just wanted to find out - do you believe this PR will go in in the short term, or will it still be a while due to the breaking change?

Reason for my asking is that a few people have asked me about which scanner they can use to get the raw bytes from a barcode so it seems like a pressing issue - I've directed them all to leave a 👍 on the linked issue - #1816 - but was thinking that if it is still going to be a while before this PR goes in, then I may release a separate plugin in the interim.

Thanks in advance for any feedback 🙂

@bparrishMines
Copy link
Contributor

Hi @marcus-bornman, thanks for the contribution. Unfortunately we don't have anyone that can work on adding and maintaining new features for this plugin. We do have people working on making ML Kit feature complete, but I can't give you a time frame for when this will be finished yet.

We do work on issues based on the number of thumbs though, so keeping the issue will help get the feature prioritized.

marcus-bornman added 2 commits November 8, 2020 08:12
…-bytes-for-barcodes

# Conflicts:
#	AUTHORS
#	README.md
#	packages/firebase_ml_vision/CHANGELOG.md
#	packages/firebase_ml_vision/README.md
#	packages/firebase_ml_vision/pubspec.yaml
@the-mars-rover the-mars-rover changed the title [firebase_ml_vision] Add rawBytes to the Barcode class (#1816) [feat!: firebase_ml_vision] Add rawBytes to the Barcode class (#1816) Nov 8, 2020
@the-mars-rover the-mars-rover changed the title [feat!: firebase_ml_vision] Add rawBytes to the Barcode class (#1816) [firebase_ml_vision] feat!: Add rawBytes to the Barcode class (#1816) Nov 8, 2020
@the-mars-rover the-mars-rover changed the title [firebase_ml_vision] feat!: Add rawBytes to the Barcode class (#1816) feat!(firebase_ml_vision): Add rawBytes to the Barcode class (#1816) Nov 8, 2020
@the-mars-rover the-mars-rover changed the title feat!(firebase_ml_vision): Add rawBytes to the Barcode class (#1816) feat(firebase_ml_vision)!: Add rawBytes to the Barcode class (#1816) Nov 8, 2020
@the-mars-rover
Copy link
Author

Pulled latest changes from master

@bparrishMines
Copy link
Contributor

cc @Salakar

@dayron9110
Copy link

News?

@dayron9110
Copy link

@dayron9110
Copy link

Any update?

@dayron9110
Copy link

News?

@rrousselGit
Copy link
Contributor

Why is this titled as feat!:? As the ! express a breaking change, but the version you suggested implies a non-breaking change.

Should this be feat: instead?

@rrousselGit
Copy link
Contributor

Also could you fix the conflicts on the test file? (reverting the changelog/pubspec should fix those conflicts)

/// Barcode bytes as they were encoded in the barcode.
///
/// Null if nothing found.
final Uint8List rawBytes;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not really fond of having the native side transmit the bytes list without the client requesting for it.
That'll make the communication slower for everyone, even those who aren't using rawBytes.

Thoughts @Salakar?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Salakar @rrousselGit Any more insight into this? :) How would you prefer to go about this alternatively?

@the-mars-rover the-mars-rover changed the title feat(firebase_ml_vision)!: Add rawBytes to the Barcode class (#1816) feat(firebase_ml_vision): Add rawBytes to the Barcode class (#1816) Apr 2, 2021
 into ml-vision-add-raw-bytes-for-barcodes

� Conflicts:
�	packages/firebase_ml_vision/CHANGELOG.md
�	packages/firebase_ml_vision/ios/Classes/BarcodeDetector.m
�	packages/firebase_ml_vision/pubspec.yaml
�	packages/firebase_ml_vision/test/firebase_ml_vision_test.dart
@the-mars-rover
Copy link
Author

Why is this titled as feat!:? As the ! express a breaking change, but the version you suggested implies a non-breaking change.

Should this be feat: instead?

Made the change :) The PR was originally a breaking change but after more recent changes it is no longer one - just forgot to update the title.

@the-mars-rover
Copy link
Author

Also could you fix the conflicts on the test file? (reverting the changelog/pubspec should fix those conflicts)

Done :)

@the-mars-rover
Copy link
Author

@rrousselGit Updated the PR based on your comments - mind taking a look again? :-)

@the-mars-rover
Copy link
Author

@rrousselGit @Salakar Hey guys :) Any update on this?

@rrousselGit
Copy link
Contributor

This seems alright to me.
But I'd like others to review it as well

Add nullable to rawBytes
@Salakar
Copy link
Member

Salakar commented May 10, 2021

Hey @marcus-bornman 👋 - appreciate this PR however unfortunately the firebase_ml_vision package is now discontinued since its APIs have been deprecated and removed from the Android & iOS Firebase SDKs - so I don't see us spending much time if any adding new features since these APIs are going away.

I'd recommend switching to the alternatives now;

  • for on-device vision APIs; switch to Google's standalone ML Kit library via google_ml_kit - you could probably send a similar PR to this package.
  • for cloud vision APIs; the recommended approach now is to use Firebase
    Authentication and Functions, which gives you a managed, serverless gateway to the Google Cloud Vision APIs. For an example Functions project see the vision-annotate-images sample project. You'd deploy this project for example and then call the cloud function from your app with your image data to get the annotation result.

Apologies for any inconvenience here and best of luck switching over the the new APIs. firebase_ml_custom is not affected by this deprecation.

Thanks

@the-mars-rover
Copy link
Author

Since the firebase_ml_vision plugin was discontinued, followers of this PR can be directed to flutter-ml/google_ml_kit_flutter#56

@firebase firebase locked and limited conversation to collaborators Jun 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants