Hi there 👋
I'm an engineer at Google Cloud. Previously I worked at HashiCorp, Chef Software, CustomInk, and some Pittsburgh-based startups.
💬 Ask me about: Go, Ruby😄 Pronouns: he/him🌍 Website
sethvargo
Follow
Pinned
3,491 contributions in the last year
Less
More
Activity overview
Contributed to
google/exposure-notifications-verification-server,
google/exposure-notifications-server,
google-github-actions/setup-gcloud
and 5 other
repositories
Contribution activity
February 2021
Created 38 commits in 2 repositories
Created a pull request in google/exposure-notifications-server that received 5 comments
Pull logger and request_id from context in jwks service
This updates the jwks service to populate and pull critical information from the request context instead of the initial context, similar to the ver…
+309
−42
•
5
comments
Opened 37 other pull requests in 2 repositories
google/exposure-notifications-server
24
merged
- Move chaff to middleware
- Move maintenance mode to middleware
- Move publish to middleware/server pattern
- Rename publishHandler -> publishServer
- Move federationin to middleware/server pattern
- Mount middlewares in other packages
- Pull context from request in export
- Use TestContext in tests
- Check if connection is valid after acquiring from the pool
- Refactor generate service to be a proper server, use new middlewares
- Update ignore_changes to avoid recurring diff
- Use custom http client and customizable timeout for jwks
- Recover from panics in main
- Update to latest gcloud in builds
- Wait for KMS keys to be ready
- Do not log lock acquisition failure when the lock is already held
- Create more precise exposure indices
- Temporarily remove exposure index creation, inline type changes
- More fine-tuning indicies
- Clean up some indexes, run in own transaction
- Only log internal errors on publish, move others to debug level
- Move DEBUG SERVER message to warning level
- Update data types and add more indicies
- Drop usage of serializable transactions
google/exposure-notifications-verification-server
12
merged
1
closed
- Add ignore_changes to prevent recurring diff
- Do not debug log on rate limiting, log on rate limited
- Highlight when a message crosses an SMS boundary
- Upgrade to gcloud 324.0.0 in builds
- Upgrade key server to main to pull in KMS fix
- Fix data race
- Add more tests for appsync
- Add more rotation tests
- Add tests for rbac
- Add more admin tests
- Fix broken envvars
- Fallback to a sentinel string if the redis auth is unset
- Include multiline and whitespace in search in SMS preview
Reviewed 24 pull requests in 3 repositories
google/exposure-notifications-verification-server 15 pull requests
- Set sample_rate to null if lb logging is not enabled.
- Update google provider version.
- Update paging and non-paging alerts
- Update example tf
- Check session idleness in login
- trim a whitespace
- Double frequency for stats
- Simple test for noop SMS
- Coverage for /user
- Add test coverage for /login submit actions
- Cover some /codes error cases
- don't pass redis password when auth disabled
- Cover expire API
- Test render of all the code pages
- Unclosed h5 tag. All json/csv as footers
google/exposure-notifications-server 8 pull requests
- change default scale to 10
- Add sandbox annotation.
- Move chaff to middleware
- Separate paging and non-paging notification channels
- change the way the generate service generates keys
- add longer timeout for migrate
- improve locking handling for background jobs
- Switch to ReadCommitted isolation level for locking
sethvargo/vault-on-gke 1 pull request
Created an issue in google/exposure-notifications-server that received 3 comments
KMS keys can be in "PENDING_GENERATION" state during rotation
While rare, we currently have a race condition when rotating keys. We create a new key via the API, but that does not guarantee the key material is…
3
comments
Opened 2 other issues in 2 repositories
google/exposure-notifications-verification-server
1
closed
google/exposure-notifications-server
1
closed
14
contributions
in private repositories
Feb 1 – Feb 6