feat: support long polling requests and event-source responses#538
Closed
feat: support long polling requests and event-source responses#538
Conversation
Member
Author
|
Needs tests |
ronag
force-pushed
the
long-polling-event-source
branch
from
6e79ed0 to
a455b52
Compare
ronag
force-pushed
the
long-polling-event-source
branch
from
a455b52 to
020f6ea
Compare
Member
Author
|
This logic is only relevant when pipelining > 1 and ensures that no more requests are enqueued. |
Codecov Report
@@ Coverage Diff @@
## master #538 +/- ##
==========================================
- Coverage 99.63% 99.56% -0.08%
==========================================
Files 16 16
Lines 1365 1375 +10
==========================================
+ Hits 1360 1369 +9
- Misses 5 6 +1
Continue to review full report at Codecov.
|
ronag
force-pushed
the
long-polling-event-source
branch
from
db70669 to
e88b0f7
Compare
ronag
force-pushed
the
main
branch
3 times, most recently
from
87a911d to
f5ec39e
Compare
ronag
force-pushed
the
main
branch
2 times, most recently
from
becd967 to
b33dffa
Compare
ronag
force-pushed
the
main
branch
2 times, most recently
from
6679898 to
4b5ed0b
Compare
ronag
force-pushed
the
main
branch
8 times, most recently
from
e4db54a to
a3994a7
Compare
ronag
force-pushed
the
main
branch
6 times, most recently
from
5d7e3e4 to
d684ce0
Compare
ronag
force-pushed
the
main
branch
2 times, most recently
from
a2ad318 to
904e045
Compare
ronag
force-pushed
the
main
branch
3 times, most recently
from
dcb1656 to
af20fdc
Compare
ronag
force-pushed
the
main
branch
2 times, most recently
from
63eab1d to
47eb207
Compare
Member
|
This is an implementation of SSR or pure long-polling? (I'm asking because I see the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.