lazy load NotificationBar #4278
Merged
Conversation
|
This pull request is being automatically deployed with Vercel (learn more).
|
|
This method just works around the issue, not fix it. We might need something like |
|
Although workaround, But I really like the improvement , and the thought |
|
I would also prefer a proper solution, and return the correct HTML tags from the server. |
chenxsan
force-pushed the
chenxsan:feature/lazy-load-notification
branch
from
e6696a5
to
ed2150a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
closes #4414
Currently the
NotificationBaris included in precompiled HTML, which means browsers would render it before we hide it with js which caused a flash of unstyled content.In this pull request,
UPDATEbutton removed.Note that we'll fix the following issue in another pull request in near future.
We have people complaining on twitter that the snippets of webpack search results show content of notification bar.
I've inspected the search results and did find something like below which is bad for user experience:
This pull request would lazy load the notification bar and stop it from included in html.