This repository was archived by the owner on Jun 30, 2022. It is now read-only.
[TypeScript][Samples] Generate package-lock for samples#3382
Merged
ryanisgrig merged 3 commits intonextfrom May 26, 2020
Merged
[TypeScript][Samples] Generate package-lock for samples#3382ryanisgrig merged 3 commits intonextfrom
ryanisgrig merged 3 commits intonextfrom
Conversation
auto-assign
bot
requested review from
darrenj,
lauren-mills,
lzc850612,
pavolum,
peterinnesmsft,
ryanisgrig,
sidmore and
taicchoumsft
darrenj
approved these changes
May 20, 2020
ryanisgrig
approved these changes
May 26, 2020
lauren-mills
added a commit
that referenced
this pull request
Jun 8, 2020
* Generate package-locks for samples * Add npmrc file updating recently added package-lock files Co-authored-by: lauren-mills <lamil@microsoft.com>
lauren-mills
added a commit
that referenced
this pull request
Jun 9, 2020
* Generate package-locks for samples * Add npmrc file updating recently added package-lock files Co-authored-by: lauren-mills <lamil@microsoft.com>
lauren-mills
added a commit
that referenced
this pull request
Jun 9, 2020
* Generate package-locks for samples * Add npmrc file updating recently added package-lock files Co-authored-by: lauren-mills <lamil@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
What is the context of this pull request? Why is it being done?
As bot-solutions@1.0.0 is published in npmjs, it's necessary to generate the
package-lockfiles for the samples.Changes
Are there any changes that need to be called out as significant or particularly difficult to grasp? (Include illustrative screenshots for context if applicable.)
Generate the
package-lock.jsonfile for Virtual Assistant Sample and Skill SampleTests
Is this covered by existing tests or new ones? If no, why not?
-
Feature Plan
Are there any remaining steps or dependencies before this issue can be fully resolved? If so, describe and link to any relevant pull requests or issues.
-
Checklist
General