adamsitnik
Follow
adamsitnik
Follow
Pinned
835 contributions in the last year
Less
More
Activity overview
Contribution activity
August 2021
Created 31 commits in 4 repositories
Created a pull request in dotnet/runtime that received 13 comments
Ensure FileStream.Position is correct after a failed|cancelled WriteAsync attempt
@stephentoub I've realised that while writes can't be incomplete, they might fail with an exception and in such cases we should update the position…
+97
−193
•
13
comments
Opened 30 other pull requests in 4 repositories
dotnet/runtime
4
open
14
merged
2
closed
- File.*AllText* optimizations
- cache SystemPageSize
- extend the NO_BUFFERING tests and cover all scenarios
- Extend MemoryCacheOptions with TrackLinkedCacheEntries
- Add Clear() to MemoryCache
- don't try to test module path if we can't load the module
- [release/5.0] Fix ReadOnlySequence created out of sliced Memory owned by MemoryManager
- Fix Length for ReadOnlySequence created out of sliced Memory owned by MemoryManager
- don't run LongModuleFileNamesAreSupported test on x86
- Support long module path
- Fix .NET 5 FileStream compat detection in the test utility project
- update Windows ARM build requirements
- fix IncompleteReadCantSetPositionBeyondEndOfFile test
- when async operation fails with ERROR_OPERATION_ABORTED, we should ignore numBytes that can be != 0
- Cancelled writes hypothesis
- PhysicalFileProvider: Remove second try on GetFileLinkTargetLastWriteTimeUtc
- Annotate unsupported APIs in System.Diagnostics.Process
- Ensure Directory.Delete works fine even if user has no ListDirectory permissions
- Fix WriteAsyncCancelledFile test failure
- see if GetArrayDataReference_NullInput_ThrowsNullRef passes on tvOS now
dotnet/performance
5
merged
dotnet/BenchmarkDotNet
1
open
3
merged
Reviewed 46 pull requests in 4 repositories
dotnet/runtime
32 pull requests
- File.*AllText* optimizations
- Fix Console.Write on iOS
- Add internal junction support to link APIs
- Enforce scatter/gather file I/O Windows API requirements et. al.
- Add Clear() to MemoryCache
- Extend MemoryCacheOptions with TrackLinkedCacheEntries
-
Remove
Net5CompatFileStreamStrategy. - cache SystemPageSize
- Augment tests for FileMode.Append
- use ArrayPool instead of having a private buffer cache
- don't try to test module path if we can't load the module
- don't run LongModuleFileNamesAreSupported test on x86
- Support long module path
- Fix .NET 5 FileStream compat detection in the test utility project
- fix IncompleteReadCantSetPositionBeyondEndOfFile test
- update Windows ARM build requirements
- Improve docs for BinaryData.ToString()
- Improve set_position to reuse buffer.
- [MacCatalyst][libraries] Update MacCatalyst as Case Preserving for tests
- Handle FileNotFound for symlinks when using polling
- Annotate unsupported APIs in System.Diagnostics.Process
- FileStream.Unix: improve DeleteOnClose when FileShare.None.
-
Fix performance for
File.GetLastWriteTimeUtcon Unix - Get better assert failure in flaky FlushAsync_ThrowsIfWriterReaderWithException test
- Ensure Directory.Delete works fine even if user has no ListDirectory permissions
- Some pull request reviews not shown.
dotnet/dotnet-api-docs
6 pull requests
dotnet/BenchmarkDotNet
5 pull requests
dotnet/performance
3 pull requests
Created an issue in dotnet/runtime that received 5 comments
How to run the test until it fails?
When trying to fix a flaky test, I usually need to run it for a while before I am able to reproduce the problem. Sample command: .\dotnet.cmd build…
5
comments
Opened 2 other issues in 2 repositories
dotnet/runtime
1
open
dotnet/BenchmarkDotNet
1
open
3
contributions
in private repositories
Aug 26 – Aug 27