Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[skip changelog] Fix release process #1163

Merged
merged 1 commit into from Feb 1, 2021
Merged

Conversation

@silvanocerza
Copy link
Contributor

@silvanocerza silvanocerza commented Feb 1, 2021

The current release process uses git to get the tag at the current
commit. It might happen that are are multiple tags when calling that
command, in cases the rc and the final release are done on the same
commit, that would make the build process to fail.

This fixes that issue by taking only one tag.

The current release process uses git to get the tag at the current
commit. It might happen that are are multiple tags when calling that
command, in cases the rc and the final release are done on the same
commit, that would make the build process to fail.

This fixes that issue by taking only one tag.
@silvanocerza silvanocerza requested a review from rsora Feb 1, 2021
@silvanocerza silvanocerza self-assigned this Feb 1, 2021
@rsora
rsora approved these changes Feb 1, 2021
@silvanocerza silvanocerza merged commit c40f1e5 into master Feb 1, 2021
12 checks passed
12 checks passed
verify-links
Details
verify-links
Details
verify-formatting
Details
verify-formatting
Details
publish-determination
Details
test-matrix (ubuntu-20.04)
Details
test-matrix (ubuntu-20.04)
Details
test-matrix (windows-latest)
Details
test-matrix (windows-latest)
Details
test-matrix (macOS-latest)
Details
test-matrix (macOS-latest)
Details
license/cla Contributor License Agreement is signed.
Details
@silvanocerza silvanocerza deleted the scerza/fix-build-tag branch Feb 1, 2021
silvanocerza added a commit that referenced this pull request Feb 1, 2021
The current release process uses git to get the tag at the current
commit. It might happen that are are multiple tags when calling that
command, in cases the rc and the final release are done on the same
commit, that would make the build process to fail.

This fixes that issue by taking only one tag.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants