Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[skip changelog] Fix core integration tests #1209

Merged
merged 1 commit into from Mar 4, 2021
Merged

Conversation

@silvanocerza
Copy link
Contributor

@silvanocerza silvanocerza commented Mar 4, 2021

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)
  • What kind of change does this PR introduce?

Fixes failing tests.

  • What is the current behavior?

Tests are failing because the number of cores in the index is changed.

  • What is the new behavior?

Tests won't fail anymore since the expected number of cores is not a fixed number.

Nope.

  • Other information:

None.


See how to contribute

@silvanocerza silvanocerza requested review from cmaglie, umbynos and rsora Mar 4, 2021
@silvanocerza silvanocerza self-assigned this Mar 4, 2021
@cmaglie
cmaglie approved these changes Mar 4, 2021
@silvanocerza silvanocerza merged commit 0169954 into master Mar 4, 2021
16 checks passed
16 checks passed
Lints Python code
Details
Lints Python code
Details
verify-links
Details
verify-links
Details
publish-determination
Details
test-matrix (ubuntu-20.04)
Details
test-matrix (ubuntu-20.04)
Details
test-matrix (windows-latest)
Details
test-matrix (windows-latest)
Details
test-matrix (macOS-latest)
Details
test-matrix (macOS-latest)
Details
publish
Details
create-test-artifacts
Details
create-test-artifacts
Details
codecov/project 37.38% (target 30.00%)
Details
license/cla Contributor License Agreement is signed.
Details
@silvanocerza silvanocerza deleted the scerza/fix-core-tests branch Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants