Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cdk/a11y): add ConfigurableFocusTrapConfig to the public API #22138

Merged

Conversation

Copy link
Member

@Splaktar Splaktar commented Mar 7, 2021

  • ConfigurableFocusTrap is already in the public API and it depends on this class
  • convert ConfigurableFocusTrapConfig from a class to an interface
  • fix alphabetization of exports

Relates to #18201. Relates to #22136.

This class and it's API documentation does not currently show up in the API docs. I am expecting that adding it to the public API will get the doc generation to include it. Please let me know if this is incorrect.

@Splaktar Splaktar added P2 docs area: cdk/a11y labels Mar 7, 2021
@Splaktar Splaktar requested a review from vanessanschmitt Mar 7, 2021
@Splaktar Splaktar self-assigned this Mar 7, 2021
@google-cla google-cla bot added the cla: yes label Mar 7, 2021
@Splaktar Splaktar requested a review from crisbeto Mar 7, 2021
@Splaktar Splaktar force-pushed the docs-api-configurable-focus-trap-config branch from f21e8ef to 60bcb1d Compare Mar 7, 2021
@Splaktar Splaktar force-pushed the docs-api-configurable-focus-trap-config branch from 60bcb1d to 186df51 Compare Mar 11, 2021
@Splaktar Splaktar requested a review from crisbeto Mar 11, 2021
@jelbourn jelbourn added the target: minor label Mar 11, 2021
Copy link
Member

@jelbourn jelbourn left a comment

LGTM

src/cdk/a11y/focus-trap/configurable-focus-trap-factory.ts Outdated Show resolved Hide resolved
- `ConfigurableFocusTrap` is already in the public API and it depends on this class
- convert `ConfigurableFocusTrapConfig` from a class to an interface
- fix alphabetization of exports

Relates to angular#18201. Relates to angular#22136.
@Splaktar Splaktar force-pushed the docs-api-configurable-focus-trap-config branch from 186df51 to 3fb4d91 Compare Mar 11, 2021
@Splaktar Splaktar added the merge ready label Mar 11, 2021
@Splaktar Splaktar assigned mmalerba and unassigned Splaktar Mar 11, 2021
@Splaktar Splaktar assigned andrewseguin and unassigned mmalerba Mar 19, 2021
@andrewseguin andrewseguin merged commit 7718947 into angular:master Mar 19, 2021
16 checks passed
@Splaktar Splaktar deleted the docs-api-configurable-focus-trap-config branch Mar 19, 2021
@angular-automatic-lock-bot
Copy link

@angular-automatic-lock-bot angular-automatic-lock-bot bot commented Apr 19, 2021

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Apr 19, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: cdk/a11y cla: yes docs merge ready P2 target: minor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants