Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extras: disable lookup-optimize in virt and block groups #2254

Merged
merged 1 commit into from Mar 17, 2021

Conversation

@xhernandez
Copy link
Contributor

@xhernandez xhernandez commented Mar 12, 2021

lookup-optimize doesn't provide any benefit for virtualized
environments and gluster-block workloads, but it's known to cause
corruption in some cases when sharding is also enabled and the volume
is expanded or shrunk.

For this reason, we disable lookup-optimize by default on those
environments.

Fixes: #2253
Change-Id: I25861aa50b335556a995a9c33318dd3afb41bf71
Signed-off-by: Xavi Hernandez xhernandez@redhat.com

lookup-optimize doesn't provide any benefit for virtualized
environments and gluster-block workloads, but it's known to cause
corruption in some cases when sharding is also enabled and the volume
is expanded or shrunk.

For this reason, we disable lookup-optimize by default on those
environments.

Fixes: #2253
Change-Id: I25861aa50b335556a995a9c33318dd3afb41bf71
Signed-off-by: Xavi Hernandez <xhernandez@redhat.com>
@xhernandez
Copy link
Contributor Author

@xhernandez xhernandez commented Mar 12, 2021

/run regression

@xhernandez
Copy link
Contributor Author

@xhernandez xhernandez commented Mar 16, 2021

/recheck smoke

@xhernandez
Copy link
Contributor Author

@xhernandez xhernandez commented Mar 16, 2021

/run regression

@xhernandez xhernandez requested review from amarts and mohit84 Mar 17, 2021
@amarts
amarts approved these changes Mar 17, 2021
@amarts amarts merged commit 2b3e3ef into gluster:devel Mar 17, 2021
11 of 12 checks passed
11 of 12 checks passed
Testing: shellcheck FAIL - please fix for merge
Details
Testing: 32-bit-build OK - 32-bit-build
Details
Testing: clang format OK - clang format
Details
Testing: comment on issue job OK - comment on issue
Details
Testing: devrpm-el7 OK - devrpm-el7
Details
Testing: devrpm-fedora OK - devrpm-fedora
Details
Testing: fedora smoke OK - fedora smoke
Details
Testing: freebsd smoke OK - freebsd smoke
Details
Testing: python lint OK - python lint
Details
Testing: regression test suite OK - No regression
Details
Testing: smoke-centos7 OK - smoke-centos7
Details
Testing: strfmt errors in a 32 build OK - no strfmt errors
Details
@xhernandez xhernandez deleted the xhernandez:issue-2253 branch Mar 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants