OnDevice markup extension added (take 2) #2687
Merged
Conversation
|
@nmetulev any concerns with exposing the AnalyticsVersion extension in |
| @@ -1428,6 +1437,7 @@ | |||
| <Name>Visual C++ 2015 Runtime for Universal Windows Platform Apps</Name> | |||
| </SDKReference> | |||
| </ItemGroup> | |||
| <ItemGroup /> | |||
michael-hawker
Nov 27, 2018
Member
Extra ItemGroup
Extra ItemGroup
|
@sonnemaf where are the icons in the new thumbnail sourced from? |
| /// </summary> | ||
| public sealed partial class OnDevicePage : IXamlRenderListener | ||
| { | ||
|
|
lindexi
Nov 30, 2018
redundant blank line.
redundant blank line.
| @@ -759,7 +759,7 @@ | |||
| "About": "The ThemeListener allows you to keep track of changes to the System Theme.", | |||
| "Icon": "/Assets/Helpers.png", | |||
| "DocumentationUrl": "https://raw.githubusercontent.com/MicrosoftDocs/WindowsCommunityToolkitDocs/master/docs/helpers/ThemeListener.md" | |||
| } | |||
| } | |||
lindexi
Nov 30, 2018
redundant space
redundant space
|
@michael-hawker Yes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Issue: #2489 and #2664
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
PR Checklist
Please check if your PR fulfills the following requirements:
Other information