Add column and row spacing to the StaggeredPanel #2839
Merged
Conversation
|
There are a couple of edge cases that I'll handle in a separate PR. |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
StaggeredPanel does not have the ability to set spacing like other panels
What is the new behavior?
Can now set new
RowSpacingandColumnSpacingpropertiesPR Checklist
Please check if your PR fulfills the following requirements:
Other information
Discussion point: There are defined columns, but there are not defined rows. Should the properties be called
ColumnSpacingandVerticalSpacing? I don't like this naming because I feel it's confusing. Why is one calledColumnwhile the other isVertical.