Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix possible cert/pfx errors. #2998

Merged
merged 1 commit into from Sep 9, 2019
Merged

Fix possible cert/pfx errors. #2998

merged 1 commit into from Sep 9, 2019

Conversation

@azchohfi
Copy link
Contributor

@azchohfi azchohfi commented Sep 9, 2019

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

Clean clone will fail to build.

What is the new behavior?

No pfx needed anymore for building the toolkit.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Pull Request has been submitted to the documentation repository instructions. Link:
  • Sample in sample app has been added / updated (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

@azchohfi azchohfi merged commit 854cc88 into master Sep 9, 2019
3 checks passed
3 checks passed
Toolkit-CI Build #5.1.0-build.251+8c3e9ce536 succeeded
Details
WIP Ready for review
Details
license/cla All CLA requirements met.
Details
@delete-merged-branch delete-merged-branch bot deleted the fixCertErrors branch Sep 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can’t perform that action at this time.