Skip to content

/ WindowsCommunityToolkit

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TemplateParts to InfiniteCanvas and consts #3188

Merged
merged 3 commits into from Mar 30, 2020
Merged

Add TemplateParts to InfiniteCanvas and consts #3188

merged 3 commits into from Mar 30, 2020

Conversation

@michael-hawker
Copy link
Member

@michael-hawker michael-hawker commented Mar 24, 2020

PR Type

  • Code style update (formatting)
  • Refactoring (no functional changes, no api changes)

What is the current behavior?

TemplateParts were not exposed for InfiniteCanvas

What is the new behavior?

Expose TemplateParts

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Pull Request has been submitted to the documentation repository instructions. Link:
  • Sample in sample app has been added / updated (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes
@michael-hawker
Add TemplateParts to InfiniteCanvas and use consts for strings
8ade803
@michael-hawker
Fix potential null reference issue with re-templated InfiniteCanvas
Loading status checks…
8272585
@msftbot
Copy link
Contributor

@msftbot msftbot bot commented Mar 24, 2020

Thanks michael-hawker for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌
@azchohfi
azchohfi approved these changes Mar 25, 2020
View changes
@michael-hawker michael-hawker added this to the 6.1 milestone Mar 30, 2020
@michael-hawker michael-hawker added this to In progress in Bugs 6.1 via automation Mar 30, 2020
@michael-hawker
Merge branch 'master' into mhawker/InfiniteCanvas-TemplatedParts
Verified
This commit was created on GitHub.com and signed with a verified signature using GitHub’s key.
GPG key ID: 4AEE18F83AFDEB23 Learn about signing commits
Loading status checks…
a13d0ac
@michael-hawker michael-hawker merged commit adf771e into master Mar 30, 2020
3 checks passed
3 checks passed
Toolkit-CI Build #6.1.0-build.26+5defe86515 succeeded
Details
WIP Ready for review
Details
license/cla All CLA requirements met.
Details
Bugs 6.1 automation moved this from In progress to Done Mar 30, 2020
@delete-merged-branch delete-merged-branch bot deleted the mhawker/InfiniteCanvas-TemplatedParts branch Mar 30, 2020
@michael-hawker michael-hawker mentioned this pull request Apr 1, 2020
Closed
29 of 36 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@azchohfi azchohfi

Assignees

@azchohfi azchohfi

Labels
controls 🎛️ improvements ✨
Projects
Bugs 6.1
  
Done
Milestone
6.1
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@michael-hawker @azchohfi @Kyaa-dost
You can’t perform that action at this time.