Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark Sample App for Debugging #3281

Merged
merged 5 commits into from May 15, 2020
Merged

Mark Sample App for Debugging #3281

merged 5 commits into from May 15, 2020

Conversation

@michael-hawker
Copy link
Member

@michael-hawker michael-hawker commented May 13, 2020

Fixes Issue while Debugging Toolkit Sample App

It's hard currently to tell which version of the Sample App installed is the Debug local version or the store version (outside of loading time). This change will make it easier for a developer working to have both versions installed and tell the two apart at a glance.

PR Type

What kind of change does this PR introduce?

  • Sample app changes

What is the current behavior?

Sample App uses same background/name as last released store app.

What is the new behavior?

Have a new name/bg image for the app to make it easy to tell apart from the store app:

image

(Store release on left, debug on right)

image

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Pull Request has been submitted to the documentation repository instructions. Link:
  • Sample in sample app has been added / updated (for bug fixes / features)
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes

Other information

@msftbot
Copy link
Contributor

@msftbot msftbot bot commented May 13, 2020

Thanks michael-hawker for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

michael-hawker and others added 2 commits May 13, 2020
Copy link
Contributor

@Kyaa-dost Kyaa-dost left a comment

@michael-hawker The debugger looks very neat and can easily be differentiated from the sample app 🙌

@michael-hawker michael-hawker merged commit 01075ff into master May 15, 2020
3 checks passed
3 checks passed
Toolkit-CI Build #6.1.0-build.86+01fc184d30 succeeded
Details
WIP Ready for review
Details
license/cla All CLA requirements met.
Details
@delete-merged-branch delete-merged-branch bot deleted the mhawker/sample-debug branch May 15, 2020
@michael-hawker michael-hawker modified the milestone: 6.1 May 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.