Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ReadOnly]RefEnumerable<T>.DangerousCreate static constructors #3645

Open
wants to merge 4 commits into
base: master
from

Conversation

@Sergio0694
Copy link
Member

@Sergio0694 Sergio0694 commented Dec 22, 2020

Closes #3641

PR Type

What kind of change does this PR introduce?

  • Feature

What is the current behavior?

There is no way to manually create a RefEnumerable<T> or a ReadOnlyRefEnumerable<T> instance.

What is the new behavior?

This PR adds a new [ReadOnly]RefEnumerable<T>.DangerousCreate static constructor.
This gives the two types feature parity on this front with the likes of [ReadOnly]Span2D<T>, that expose this API.

PR Checklist

Please check if your PR fulfills the following requirements:

  • Tested code with current supported SDKs
  • Pull Request has been submitted to the documentation repository instructions. Link:
  • Sample in sample app has been added / updated (for bug fixes / features)
  • New major technical changes in the toolkit have or will be added to the Wiki e.g. build changes, source generators, testing infrastructure, sample creation changes, etc...
  • Tests for the changes have been added (for bug fixes / features) (if applicable)
  • Header has been added to all new source files (run build/UpdateHeaders.bat)
  • Contains NO breaking changes
@Sergio0694 Sergio0694 added this to the 7.0 milestone Dec 22, 2020
@Sergio0694 Sergio0694 added this to In progress in Features 7.0 via automation Dec 22, 2020
@msftbot msftbot bot added the in progress 🚧 label Dec 22, 2020
@msftbot
Copy link
Contributor

@msftbot msftbot bot commented Dec 22, 2020

Thanks Sergio0694 for opening a Pull Request! The reviewers will test the PR and highlight if there is any conflict or changes required. If the PR is approved we will proceed to merge the pull request 🙌

@michael-hawker michael-hawker removed this from In progress in Features 7.0 Jan 6, 2021
@msftbot msftbot bot removed this from the 7.0 milestone Jan 6, 2021
@Kyaa-dost Kyaa-dost added this to the 7.0 milestone Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.