[SourceKit/CursorInfo] Mark dynamic calls #36508
Merged
Conversation
|
@swift-ci please test |
| if (!TyD) | ||
| return false; | ||
|
|
||
| if (isa<StructDecl>(TyD) || isa<EnumDecl>(TyD) || D->isFinal()) |
bnbarham
Mar 19, 2021
Author
Contributor
isFinal is new here
isFinal is new here
|
Build failed |
|
Build failed |
The cursor info request also needs to output whether a call is "dynamic" or not, move the functions related to this out of Index.cpp and into IDE/Utils.cpp. Also cleanup the `TrailingExpr` handling in `CursorInfoResolver` - it only needs the first expression.
Adds two new fields to the cursor info response: 1. is_dynamic: whether a call is dynamic 2. receivers: receivers of the call (USRs) Users of the CursorInfo request can use "is_dynamic" to decide whether to lookup overrides or not, and then the "receivers" as the starting point of the lookup. Resolves rdar://75385900
|
@swift-ci please test |
bnbarham
changed the title
|
Build failed |
|
@swift-ci please test Linux platform |
|
Build failed |
|
@swift-ci please test Linux platform |
|
@benlangmuir going to merge but let me know if there's any changes you'd like me to make. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Adds two new fields to the cursor info response:
Users of the CursorInfo request can use "is_dynamic" to decide whether
to lookup overrides or not, and then the "receivers" as the starting
point of the lookup.
Resolves rdar://75385900