Add useFullBounds option for getWindowBoundsCentered() and centerWindow()#44
Merged
sindresorhus merged 9 commits intosindresorhus:mainfrom Apr 6, 2021
lacymorrow:fix/41
Merged
Add useFullBounds option for getWindowBoundsCentered() and centerWindow()#44sindresorhus merged 9 commits intosindresorhus:mainfrom lacymorrow:fix/41
useFullBounds option for getWindowBoundsCentered() and centerWindow()#44sindresorhus merged 9 commits intosindresorhus:mainfrom
lacymorrow:fix/41
Conversation
Contributor
Author
|
@sindresorhus not sure what you would like to call it but I think |
Owner
|
Maybe |
sindresorhus
requested changes
Mar 17, 2021
Owner
|
You also need to update |
Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>
Contributor
Author
|
Ready for another review |
Owner
|
You have a lint violation. |
Co-authored-by: Sindre Sorhus <sindresorhus@gmail.com>
Contributor
Author
|
Fixed up |
sindresorhus
changed the title
getWindowBoundsCentereduseFullBounds option
sindresorhus
changed the title
useFullBounds optionuseFullBounds option for getWindowBoundsCentered() and centerWindow()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows for centered windows to ignore the space taken by the Windows taskbar or the MacOS dock so that programs can accurately be centered.
Fixes #41