Add GCS Action #121
Merged
Add GCS Action #121
Conversation
…-actions into add-gcs-action
|
Taking a look at the failing test, it appears the SA being used for the int-tests is missing a required permission: "##[error]*** does not have storage.objects.create access to the Google Cloud Storage object." |
|
@craigdbarber I was working with @averikitsch to figure this out. The permissions do seem to be correct in the project, I was able to get this working on a different service account with the same role. |
|
LGTM |
|
ping. Do you want to go ahead and merge this? |
bharathkkb
merged commit d72625c
into
master
32 checks passed
32 checks passed
cla/google
All necessary CLAs are signed
|
@averikitsch sorry missed Craig's approval. I have merged it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
replaces #55
fixes #32
Add a native GCS Upload Action using google-cloud/storage