Skip to content

Allow optimizing over Bigfloat intervals#45

Merged
dpsanders merged 4 commits intoJuliaIntervals:masterfrom
ericphanson:eph/allow-bigfloats
Dec 14, 2019
Merged

Allow optimizing over Bigfloat intervals#45
dpsanders merged 4 commits intoJuliaIntervals:masterfrom
ericphanson:eph/allow-bigfloats

Conversation

@ericphanson
Copy link
Contributor

@ericphanson ericphanson commented Dec 9, 2019

I looked for something like the numeric_type function I introduce here in IntervalArithmetic.jl but didn't see anything, so I just defined it here. Fixes #43.

@codecov-io
Copy link

codecov-io commented Dec 9, 2019

Codecov Report

Merging #45 into master will increase coverage by 0.48%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #45      +/-   ##
==========================================
+ Coverage   89.06%   89.55%   +0.48%     
==========================================
  Files           4        4              
  Lines          64       67       +3     
==========================================
+ Hits           57       60       +3     
  Misses          7        7
Impacted Files Coverage Δ
src/optimise.jl 95.23% <100%> (+0.79%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8c69987...319d92e. Read the comment docs.

@dpsanders
Copy link
Member

LGTM, thanks a lot!

Could you please bump the version in Project.toml to 0.4.1?
(I don't know if I can edit Pull Requests myself)

@dpsanders
Copy link
Member

Apparently you can give me permission to modify your PR like this:
https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/allowing-changes-to-a-pull-request-branch-created-from-a-fork

But doesn't make sense for this particular one.

@ericphanson
Copy link
Contributor Author

ericphanson commented Dec 12, 2019

Sure, done. You won't be able to get it automerged though, since there's unbounded compat. Probably instead of e.g.

IntervalRootFinding = "≥ 0.4.0"

you want something like

IntervalRootFinding = "0.4, 0.5"

which means versions in the interval [0.4, 0.6). I'm not really sure what versions are compatible though.

@dpsanders
Copy link
Member

Hmm. Why does this package even need IntervalRootFinding?

Anyway, could you go ahead and make that change too please?

@ericphanson
Copy link
Contributor Author

It doesn't, nor does it seem to need IntervalConstraintProgramming. I'll try and clean up the dependencies and fix the compat.

@ericphanson
Copy link
Contributor Author

Turns out DataStructures, ForwardDiff, IntervalConstraintProgramming, and IntervalRootFinding were all unneeded. Makes the compat much easier to figure out :)

@dpsanders
Copy link
Member

Most of those packages are needed by various of the open PRs. But then they should be added back in in those PRs I guess!

@dpsanders dpsanders merged commit 3476f34 into JuliaIntervals:master Dec 14, 2019
@ericphanson ericphanson deleted the eph/allow-bigfloats branch December 14, 2019 15:17
@dpsanders
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug when using BigFloat interval

3 participants