Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shortcuts for view > zoom don't work #296

Open
ckerr opened this issue Jan 23, 2020 · 3 comments
Open

shortcuts for view > zoom don't work #296

ckerr opened this issue Jan 23, 2020 · 3 comments

Comments

@ckerr
Copy link
Member

@ckerr ckerr commented Jan 23, 2020

As demoed by Andy in the training sessions 😄

@erickzhao
Copy link
Member

@erickzhao erickzhao commented Jan 23, 2020

Did a little digging, seems like this is an outstanding bug from Electron 3 (link to issue: electron/electron#15496).

A workaround that's promising is manually adding an accelerator, although the shortcut displayed will be off (link to workaround: electron/electron#15496 (comment)).

@codebytere
Copy link
Member

@codebytere codebytere commented Jan 24, 2020

@ckerr it does work, but owing to shifting needs lost in translation you need to do `Cmd+Shift+Plus" for zoom in

@bavulapati
Copy link

@bavulapati bavulapati commented Oct 27, 2020

Can the shortcut for zoomIn be changed to Cmd + equals instead of Cmd + Plus ?
Noticed this usage by Visual studio code

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.