Skip to content

/ zx

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chore/readme grammar #1

Merged
merged 3 commits into from May 7, 2021
Merged

Chore/readme grammar #1

merged 3 commits into from May 7, 2021
+3 −3

Conversation

@thescientist13
Copy link
Contributor

@thescientist13 thescientist13 commented May 6, 2021

Fixes N / A

Just a couple small, minor grammar tweaks in the README.

It's a good idea to open an issue first for discussion.

  • Tests pass
  • Appropriate changes to README are included in PR

I tried to run tests just to be safe, but yarn test and npm run test both failed for me with

% npm run test

> zx@1.0.2 test /Users/owenbuckley/Workspace/github/forks/zx
> zx test.mjs

sh: zx: command not found

Couldn't find any notes in contributing.md but let me know if there is anything else you need.
@thescientist13
minor grammar fix
Loading status checks…
a519c38
@thescientist13
minor grammar fix
Loading status checks…
51e8994
@wadie
Copy link

@wadie wadie commented May 6, 2021 •
edited

Also remove the s in languages on line 21. 😅

people usually choose a more convenient programming languages.
@sadortun
sadortun approved these changes May 7, 2021
View changes
@thescientist13
minor grammar fix
Loading status checks…
363a2a7
@sadortun
sadortun approved these changes May 7, 2021
View changes
@azu azu mentioned this pull request May 7, 2021
Merged
0 of 2 tasks complete
@antonmedv
Copy link
Collaborator

@antonmedv antonmedv commented May 7, 2021

Hi 👋, thanks for proofreading))
Please, head over to https://cla.developers.google.com/ to sign CLA.
@antonmedv antonmedv merged commit 4238bf0 into google:main May 7, 2021
1 check passed
1 check passed
@google-cla
cla/google All necessary CLAs are signed
@antonmedv antonmedv mentioned this pull request May 7, 2021
Closed
1 of 2 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sadortun sadortun

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

4 participants
@thescientist13 @wadie @antonmedv @sadortun