Define which dependencies are shared among workspace projects #375
Conversation
isaacs
changed the title
ljharb
reviewed
May 5, 2021
| If `a` declares a dependency on `foo`, and `b` does _not_ declare that | ||
| dependency, then the code in `b` can call `require('foo')` and it will work | ||
| without any errors in development. But when `b` is published, and | ||
| subsequently installed as a standalone project, it fails to find the `foo` | ||
| dependency. |
we may want to explicitly declare it as a non-goal to address "if foo depends on c, a can require('c') even though it doesn't declare that dependency"?
| 2. A workspace that has a peer dependency should share the same instance of | ||
| that peer dependency with all other workspace projects, unless | ||
| explicitly marked for isolation. |
Suggested change
| 2. A workspace that has a peer dependency should share the same instance of | |
| that peer dependency with all other workspace projects, unless | |
| explicitly marked for isolation. | |
| 2. A workspace that has a peer dependency should share the same instance of | |
| that peer dependency with all other workspace projects that declare that peer dependency, unless | |
| explicitly marked for isolation. |
| 3. A workspace should not be able to load any package that it does not have | ||
| an explicit dependency on, with the exception of dependencies declared | ||
| explicitly at a level higher than them in the directory tree. |
Suggested change
| 3. A workspace should not be able to load any package that it does not have | |
| an explicit dependency on, with the exception of dependencies declared | |
| explicitly at a level higher than them in the directory tree. | |
| 3. A workspace should not be able to load any package that it does not have | |
| an explicit dependency on (direct, or possibly transitive), with the exception of dependencies declared | |
| explicitly at a level higher than them in the directory tree. |
5 tasks
isaacs
force-pushed
the
isaacs/workspace-dependency-sharing
branch
from
178001d
to
d02ad26
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
References
The text was updated successfully, but these errors were encountered: