jmagman
Follow
Pinned
2,205 contributions in the last year
Less
More
Contribution activity
May 2021
Created 39 commits in 3 repositories
Created 1 repository
- jmagman/file.dart Dart
Created a pull request in flutter/plugins that received 5 comments
[google_maps_flutter] Unpin iOS GoogleMaps pod dependency version
The plugins and flutter infrastructure has migrated past Xcode 11.5, which is related to the original reason this was pinned. A failure will look l…
+6
−3
•
5
comments
Opened 47 other pull requests in 3 repositories
flutter/plugins
9
open
19
merged
- [connectivity] Ignore Reachability pointer to int cast warning
- [video_player] Fix pointer value to boolean conversion analyzer warnings
- [image_picker] Fix camera alert localization analyzer warning
- Add xctest --xclogparser to test runner
- [sensors] Update Cirrus image to Xcode 12.5, fix sensors analyzer warning
- [webview_flutter] Migrate maven repo from jcenter to mavenCentral
- [wifi_info_flutter] Migrate maven repo from jcenter to mavenCentral
- [video_player] Migrate maven repo from jcenter to mavenCentral
- [shared_preferences] Migrate maven repo from jcenter to mavenCentral
- [share] Migrate maven repo from jcenter to mavenCentral
- [sensors] Migrate maven repo from jcenter to mavenCentral
- [quick_actions] Migrate maven repo from jcenter to mavenCentral
- [path_provider] Migrate maven repo from jcenter to mavenCentral
- [package_info] Migrate maven repo from jcenter to mavenCentral
- [local_auth] Migrate maven repo from jcenter to mavenCentral
- [in_app_purchase] Migrate maven repo from jcenter to mavenCentral
- [image_picker] Migrate maven repo from jcenter to mavenCentral
- [google_sign_in] Migrate maven repo from jcenter to mavenCentral
- [google_maps_flutter] Migrate maven repo from jcenter to mavenCentral
- [flutter_plugin_android_lifecycle] Migrate maven repo from jcenter to mavenCentral
- [espresso] Migrate maven repo from jcenter to mavenCentral
- [device_info] Migrate maven repo from jcenter to mavenCentral
- [connectivity] Migrate maven repo from jcenter to mavenCentral
- [camera] Migrate maven repo from jcenter to mavenCentral
- [battery] Migrate maven repo from jcenter to mavenCentral
- Some pull requests not shown.
flutter/flutter
17
merged
1
closed
- Remove more mocks from error_handling_io_test
- Default --no-tree-shake-icons to false for 'flutter build bundle'
- Run update packages, pick up "file" version 6.1.1
- Enable win_gradle_plugin_light_apk_test and mark unflaky
- Mark win_build_tests_2_3 not flaky
- Mark mac_ios_platform_channels_benchmarks_ios not flaky
- Fix 'You example app code is in' typo
- Remove symroot from generated iOS Xcode build settings
- Replace testUsingContext with testWithoutContext in protocol_discovery_test
- Replace testUsingContext with testWithoutContext in a few places
- Tool exit on xcodebuild -list when Xcode project is corrupted
- Turn on win_build_tests_2_3 shard, skip 'build windows' tests
- Mark animated_image_gc_perf not flaky
- Mark linux_platform_channels_benchmarks not flaky
- Force LANG=en_US.UTF-8 in test runner
- Prevent macOS individual pod framework signing
- Add posix permission chown suggestion to io error handling
- Standardize build system environment defines derived from build info
google/file.dart
1
merged
Reviewed 35 pull requests in 4 repositories
flutter/flutter 30 pull requests
- [flutter_tools] remove mocks from compile expression unit test
- [flutter_tools] remove special casing of web listview requests
- Migrate manual_tests to null safety
- [flutter_tools] replace most of the mocks in cache_test.dart
- [flutter_tools] remove mocks from downgrade and devices test
- [flutter_tools] remove mocks from application_package_test
- [flutter_tools] remove some mocks from web resident runner tests
- Replace testUsingContext with testWithoutContext in a few places
- Tool exit on xcodebuild -list when Xcode project is corrupted
- [flutter_tools] remove mocks from doctor test
- [flutter_tools] make failures to unforward android port non-fatal
- [flutter_tools] use try to delete in web cache
- [flutter_tools] remove mocks from device test
- Re-enable win_build_tests_2_3.
- [flutter_tools] remove mocks from devices test
- Force LANG=en_US.UTF-8 in test runner
- [dev] Add code owners on *_builders.json
- Re-land: Allow users to pass in Xcode build settings as env variables to flutter build macos FLUTTER_XCODE_
- Fix missing logger for Driver.reuseApplication
- Add posix permission chown suggestion to io error handling
- Fix prepare_package.dart not updating base_url
- Fix iOS Codesign error
- [flutter_conductor] Apply cherrypicks to local checkouts if they merge cleanly
- Standardize build system environment defines derived from build info
- [flutter_tools] remove even more mocks
- Some pull request reviews not shown.
flutter/flutter-intellij 2 pull requests
flutter/infra 2 pull requests
flutter/engine 1 pull request
Created an issue in flutter/flutter that received 5 comments
Adding ARM iOS simulator times out the engine artifacts build
Adding the ARM iOS simulator to the Mac iOS Engine builder causes the tasks to take an additional 15 minutes, which pushes the build over the timeo…
5
comments
Opened 14 other issues in 2 repositories
flutter/flutter
9
open
4
closed
- connectivity plugin has Reachability analyzer error: cast to smaller integer type 'unsigned int' from 'Reachability *' [-Werror,-Wpointer-to-int-cast]
- image_picker analyzer warnings: User-facing text should use localized string macro
- video_player analyzer warnings: Converting a pointer value of type 'NSNumber * _Nullable' to a primitive boolean value; instead, either compare the pointer to nil or call -boolValue
- sensor plugin analyzer warning: FLTSensorsPlugin.m:37: this old-style function definition is not preceded by a prototype [-Wstrict-prototypes]
- Failures in gcloud build steps should be infra failures, not test failures
- Migrate android plugins from jcenter to mavenCentral
- linux_android_view_scroll_perf__timeline_summary failing, SIGABRT
- Log processes running before and after a test runs in luci builder to detect process leaks
- hot_mode_dev_cycle_macos_target__benchmark leaves 4 gallery apps running after test completes
- Add tool logging functionality to warn a subcommand is taking longer than expected, without timing out
- ios_app_with_extensions_test fails on ARM M1 mac
- Releases json manifest "base_url" is old "flutter_infra" storage bucket
- Allow add-to-app Flutter.xcframework to be consumed as a Swift Package