Pinned
1,221 contributions in the last year
Less
More
Activity overview
Contribution activity
May 2021
Created 15 commits in 3 repositories
Created a pull request in flutter/flutter that received 30 comments
Add a script that will find the appropriate commit in another repository
The idea is that we could use this script, for example, in the engine repo to figure out which flutter commit to use to run the framework tests in …
+102
−0
•
30
comments
Opened 12 other pull requests in 3 repositories
flutter/flutter
9
merged
1
open
- Migrate the navigator API to routeInformationUpdated.
- Migrate to ChannelBuffers.push
- Revert "Migrate to ChannelBuffers.push"
- More toStrings and tests for physics, better docs
- Add flutter_tools to trigger list for skp_generator
- Migrate to ChannelBuffers.push
- Refactor MethodChannel and remove redundant OptionalMethodChannel methods
- Be more consistent about how we mark classes that can't be extended.
- Clean up some old and obsolete TODOs of mine
- Fix extra blank lines in logger output
flutter/plugins
1
merged
flutter/engine
1
merged
Reviewed 30 pull requests in 6 repositories
flutter/flutter 21 pull requests
- Add a script that will find the appropriate commit in another repository
- More toStrings and tests for physics, better docs
- Improve WebDriver error message
- [devicelab] await flutter create call in platform channels benchmark
- Revert "Init licenses for test bindings (#81961)"
- Add initial test owners for framework post-submit tests
- ExpansionPanelList elevation as double
- Gesture recognizer cleanup
- Enable library_private_types_in_public_api lint
- Add some examples of widgets that support visual density
- Refactor MethodChannel and remove redundant OptionalMethodChannel methods
- remove unnecessary String.toString()
- Turn off directives_ordering lint when analyzing samples
- Integrate package:flutter_lints into templates
- Add doc links to RawGestureDetector
- [flutter drive] Do not start dds if --no-dds
- Fixed some trivial formatting issues in test/material/popup_menu_test.dart
- Change elevation to double of MergeableMaterial
- Fix extra blank lines in logger output
- Update documentation for scrollUntilVisible and friends.
- [flutter_tools] remove last android sdk mock
flutter/packages 4 pull requests
flutter/engine 2 pull requests
flutter/plugins 1 pull request
flutter/flutter_markdown 1 pull request
flutter/cupertino_icons 1 pull request
Created an issue in flutter/flutter that received 18 comments
Update lcov.info file
We should resume generating the lcov.info file, which we stopped updating at some point.
To generate it, run flutter test --coverage in the package…
18
comments
Opened 13 other issues in 3 repositories
flutter/flutter
8
open
2
closed
- Consider refactoring how SystemNavigator clients operate
- negative-control web_ui test outputs stack trace and error to console
- Archive flutter_clock repo
- Consider refactoring Link widget
- API docs for SystemNavigator.routeInformationUpdated and SystemNavigator.routeUpdated
- Possible flutter_tools refactor: only refer to assets via their CachedArtifact objects
- Encoding shader warm-up more efficiently
- Autosubmit bot should refuse to land code without tests or test exemption
- Autosubmit bot should check that two people with commit access were involved
- Audit trail for autocommit bot