etcd in tests to assert equality uses mixed https://github.com/stretchr/testify/assert and etcd' own testutil.AssertEqual function. This issue suggests using github.com/stretchr/testify/assert.Equals everywhere and removing testutil.AssertEqual function.

Example of what we want everywhere: https://github.com/etcd-io/etcd/blob/e2d67f2e3bfa6f72178e26557bb22cc1482c418c/server/datadir/datadir

Join tokens are created by the create_join_token() SQL builtin and
returned as base64 encoded strings.

• To account for any future
  modifications to the join token format, the marshalled form of it
  should have a version number in it at a fixed offset (ideally 0)
  in addition to all the existing fields. This will ease in any future
  updates to the join token format.
• the base64 fo

After PR #10402 is merged, we need to add some test cases for postgresql start/end transaction statements, including parse result tests and rewrite tests.

If you are a newbie, you can use the SQLParserParameterizedTest and ShardingSQLRewriterParameterizedTest classes as the entrance to understand the logic of parsing tests and rewriting tests.

If you are interested, please leave a com

fdbcli flags currently contain a mixture of _ and - (probably for historic reasons). I would propose to unify the flags and only use either _ or - personally I tend to hyphens like recommended in the POSXI standard (https://www.gnu.org/software/libc/manual/html_node/Argument-Syntax.html). Current fdbcli help output:

FoundationDB CLI 6.2 (v6.2.29)
usage: /usr/bin/fdb/6.2/fdbcli

Hello Philip!
I think there is an issue with this part of the code of rqlite (store/store.go).

func (s *Store) Database(leader bool) ([]byte, error) {
	if leader && s.raft.State() != raft.Leader {
		return nil, ErrNotLeader
	}
	// Ensure only one snapshot can take place at once, and block all queries.
	s.mu.Lock()
	defer s.mu.Unlock()

	f, err := ioutil.TempFile("", "rqlilte-snap-

Would be nice to have an explicit gauge of how long a server has been up. This would be useful in case of server restarts.

Easiest would be to use our new Lag metric facility, eg: MillisLag and maybe even set it up at server registration, eg: RpcAndWebServerBase::GenerateInstanceID

Currently, there is no authentication in our MongoDB tests.
Setting MONGO_INITDB_ROOT_USERNAME and MONGO_INITDB_ROOT_PASSWORD environment variables enable auth in MongoDB docker. https://hub.docker.com/_/mongo

Use case:
Right now one can only use date_trunc() to easily define time buckets. date_trunc() only supports predefine time intervals like 1 minute, 1 hour, etc. . In time-series use cases it is often necessary to define different time bucket sizes like e.g. '5 minutes' or '20 minutes'

a workaround for this is the - error prone - integer division on the timestamp e.g.

S

Currently we don't have any mechanism to limit the maximum number of clients that could be handled simultaneously.

This feature should be designed properly. Here is some clue: https://redis.io/topics/clients#maximum-number-of-clients

Now that we support more than 1 data type, we should include the values data type in cache nodes. This give us a way of easily identifying what type of data a key points to e.g. string, queue (and more types in the future)

Currently a cache node object consists of a Key, a Value and a TTL. We should also add a field specifying the type of the Value