Skip to content

/ winforms

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add intellisense blob as part of native toolset restore and integrate xmls into package #1241

Merged
merged 3 commits into from Jun 28, 2019
Merged

Add intellisense blob as part of native toolset restore and integrate xmls into package #1241

merged 3 commits into from Jun 28, 2019

Conversation

@vatsan-madhavan
Copy link
Member

@vatsan-madhavan vatsan-madhavan commented Jun 27, 2019

@AdamYoblick Here is a basic outline that on-boards the intellisense blob to your build process. You can build on top of this and add relevant targets to integrate the right xmls into your transport package.

Feel free to close the PR and cherry-pick the relevant commit directly, or use the change shown here however you want.
@vatsan-madhavan
Add intellisense blob as part of native toolset restore
0dc7f9d
@vatsan-madhavan vatsan-madhavan requested a review from dotnet/dotnet-winforms as a code owner Jun 27, 2019
@AdamYoblick
Copy link
Member

@AdamYoblick AdamYoblick commented Jun 27, 2019

Woo thanks @vatsan-madhavan ! Really appreciate this. I won't have time to get to this today but this is my most important task tomorrow as we need to get it done before we snap on Monday.
@vatsan-madhavan
Copy link
Member Author

@vatsan-madhavan vatsan-madhavan commented Jun 27, 2019

After the initial restore process (either during a build, or after running restore.cmd), you should see something like this being generated. This would be available before your main build process (for build.proj) begins.

You should be able to gather what you need from this location and incorporate them into Microsoft.Private.Winforms.nupkg\ref\netcoreapp3.0\

$(RepoRoot)WINFORMS\.TOOLS\NATIVE\BIN\DOTNET-API-DOCS_NETCOREAPP3.0\0.0.0.1
|   version.txt.txt
|   
\---_intellisense
    \---netcore-3.0
            Accessibility.xml
            Microsoft.CSharp.xml
            Microsoft.VisualBasic.Core.xml
            Microsoft.Win32.Primitives.xml
            PresentationCore.xml
            PresentationFramework.Aero.xml
            PresentationFramework.Aero2.xml
            PresentationFramework.AeroLite.xml
            PresentationFramework.Classic.xml
            PresentationFramework.Luna.xml
            PresentationFramework.Royale.xml
            PresentationFramework.xml
            PresentationUI.xml
            ReachFramework.xml
            System.Buffers.xml
            System.Collections.Concurrent.xml
            System.Collections.Immutable.xml
            System.Collections.NonGeneric.xml
            System.Collections.Specialized.xml
            System.Collections.xml
            System.ComponentModel.Annotations.xml
            System.ComponentModel.EventBasedAsync.xml
            System.ComponentModel.Primitives.xml
            System.ComponentModel.TypeConverter.xml
            System.ComponentModel.xml
            System.Console.xml
            System.Data.Common.xml
            System.Diagnostics.Contracts.xml
            System.Diagnostics.Debug.xml
            System.Diagnostics.DiagnosticSource.xml
            System.Diagnostics.FileVersionInfo.xml
            System.Diagnostics.Process.xml
            System.Diagnostics.StackTrace.xml
            System.Diagnostics.TextWriterTraceListener.xml
            System.Diagnostics.Tools.xml
            System.Diagnostics.TraceSource.xml
            System.Diagnostics.Tracing.xml
            System.Drawing.Primitives.xml
            System.IO.Compression.Brotli.xml
            System.IO.Compression.xml
            System.IO.Compression.ZipFile.xml
            System.IO.FileSystem.DriveInfo.xml
            System.IO.FileSystem.Watcher.xml
            System.IO.FileSystem.xml
            System.IO.IsolatedStorage.xml
            System.IO.MemoryMappedFiles.xml
            System.IO.Pipes.xml
            System.Linq.Expressions.xml
            System.Linq.Parallel.xml
            System.Linq.Queryable.xml
            System.Linq.xml
            System.Memory.xml
            System.Net.Http.xml
            System.Net.HttpListener.xml
            System.Net.Mail.xml
            System.Net.NameResolution.xml
            System.Net.NetworkInformation.xml
            System.Net.Ping.xml
            System.Net.Primitives.xml
            System.Net.Requests.xml
            System.Net.Security.xml
            System.Net.ServicePoint.xml
            System.Net.Sockets.xml
            System.Net.WebClient.xml
            System.Net.WebHeaderCollection.xml
            System.Net.WebProxy.xml
            System.Net.WebSockets.Client.xml
            System.Net.WebSockets.xml
            System.Numerics.Vectors.xml
            System.ObjectModel.xml
            System.Printing.xml
            System.Reflection.DispatchProxy.xml
            System.Reflection.Emit.ILGeneration.xml
            System.Reflection.Emit.Lightweight.xml
            System.Reflection.Emit.xml
            System.Reflection.Metadata.xml
            System.Reflection.Primitives.xml
            System.Reflection.TypeExtensions.xml
            System.Resources.ResourceManager.xml
            System.Resources.Writer.xml
            System.Runtime.CompilerServices.Unsafe.xml
            System.Runtime.CompilerServices.VisualC.xml
            System.Runtime.Extensions.xml
            System.Runtime.InteropServices.RuntimeInformation.xml
            System.Runtime.InteropServices.WindowsRuntime.xml
            System.Runtime.InteropServices.xml
            System.Runtime.Intrinsics.xml
            System.Runtime.Loader.xml
            System.Runtime.Numerics.xml
            System.Runtime.Serialization.Formatters.xml
            System.Runtime.Serialization.Json.xml
            System.Runtime.Serialization.Primitives.xml
            System.Runtime.Serialization.Xml.xml
            System.Runtime.xml
            System.Security.Claims.xml
            System.Security.Cryptography.Algorithms.xml
            System.Security.Cryptography.Csp.xml
            System.Security.Cryptography.Encoding.xml
            System.Security.Cryptography.Primitives.xml
            System.Security.Cryptography.X509Certificates.xml
            System.Security.Principal.xml
            System.Text.Encoding.Extensions.xml
            System.Text.Json.xml
            System.Text.RegularExpressions.xml
            System.Threading.Overlapped.xml
            System.Threading.Tasks.Dataflow.xml
            System.Threading.Tasks.Parallel.xml
            System.Threading.Tasks.xml
            System.Threading.Thread.xml
            System.Threading.ThreadPool.xml
            System.Threading.Timer.xml
            System.Threading.xml
            System.Transactions.Local.xml
            System.Web.HttpUtility.xml
            System.Windows.Controls.Ribbon.xml
            System.Windows.Forms.Design.Editors.xml
            System.Windows.Forms.Design.xml
            System.Windows.Forms.xml
            System.Windows.Input.Manipulations.xml
            System.Windows.Presentation.xml
            System.Xaml.xml
            System.Xml.ReaderWriter.xml
            System.Xml.XDocument.xml
            System.Xml.XmlSerializer.xml
            System.Xml.XPath.XDocument.xml
            System.Xml.XPath.xml
            UIAutomationClient.xml
            UIAutomationClientsideProviders.xml
            UIAutomationProvider.xml
            UIAutomationTypes.xml
            WindowsFormsIntegration.xml
@vatsan-madhavan
Introducing a target to copy intellisense xml's to ref\ folders after…
89c5310 
… build and include them into package ref folder
@vatsan-madhavan vatsan-madhavan changed the title Add intellisense blob as part of native toolset restore Add intellisense blob as part of native toolset restore and integrate xmls into package Jun 28, 2019
@vatsan-madhavan
Add support for PackageAsRefAndLib (Accessibility.ilProj)
f61ed5e
@AdamYoblick
Copy link
Member

@AdamYoblick AdamYoblick commented Jun 28, 2019

Looks great, thanks so much again Vatsan. For reference, he's what the ref folder looks like in the package now:
image
@AdamYoblick AdamYoblick merged commit d67887d into master Jun 28, 2019
3 checks passed
3 checks passed
@wip
WIP Ready for review
Details
@azure-pipelines
dotnet-winforms CI Build #20190628.2 succeeded
Details
license/cla All CLA requirements met.
Details
@AdamYoblick AdamYoblick deleted the dev/vatsan/intellisense-xmls branch Jun 28, 2019
@AdamYoblick AdamYoblick self-requested a review Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotnet/dotnet-winforms dotnet-winforms

@AdamYoblick AdamYoblick

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
@vatsan-madhavan @AdamYoblick