Skip to content

/ node

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error: async hook stack has become corrupted (actual: 73, expected: 0) #38814

Closed
Hongbo-Miao opened this issue May 26, 2021 · 5 comments
Closed

Error: async hook stack has become corrupted (actual: 73, expected: 0) #38814

Hongbo-Miao opened this issue May 26, 2021 · 5 comments
Labels
async_hooks

Comments

@Hongbo-Miao
Copy link

@Hongbo-Miao Hongbo-Miao commented May 26, 2021 •
edited

  • Version: 16.2.0
  • Platform: Darwin 20.3.0 Darwin Kernel Version 20.3.0: Thu Jan 21 00:07:06 PST 2021; root:xnu-7195.81.3~1/RELEASE_X86_64 x86_64
  • Subsystem:

What steps will reproduce the bug?

Clone the repo: https://github.com/Hongbo-Miao/bug-nodejs-16

nvm use 16.2.0
npm install
npm run dev

How often does it reproduce? Is there a required condition?

The server will first run successfully. However, if you hit any endpoint such as openning http://localhost:5000, the server will crash.

What is the expected behavior?

Expecting the app not crash.

What do you see instead?

Crash with error:

Error: async hook stack has become corrupted (actual: 73, expected: 0)
 1: 0x10a031d5b node::AsyncHooks::pop_async_context(double) [/Users/homiao/.nvm/versions/node/v16.2.0/bin/node]
 2: 0x10a031b0c node::InternalCallbackScope::Close() [/Users/homiao/.nvm/versions/node/v16.2.0/bin/node]
 3: 0x10a0315de node::InternalCallbackScope::~InternalCallbackScope() [/Users/homiao/.nvm/versions/node/v16.2.0/bin/node]
 4: 0x10a0a2b88 node::Environment::RunTimers(uv_timer_s*) [/Users/homiao/.nvm/versions/node/v16.2.0/bin/node]
 5: 0x10aaf6877 uv__run_timers [/Users/homiao/.nvm/versions/node/v16.2.0/bin/node]
 6: 0x10aafb0ad uv_run [/Users/homiao/.nvm/versions/node/v16.2.0/bin/node]
 7: 0x10a032ea4 node::SpinEventLoop(node::Environment*) [/Users/homiao/.nvm/versions/node/v16.2.0/bin/node]
 8: 0x10a143414 node::NodeMainInstance::Run(node::EnvSerializeInfo const*) [/Users/homiao/.nvm/versions/node/v16.2.0/bin/node]
 9: 0x10a0cf97d node::Start(int, char**) [/Users/homiao/.nvm/versions/node/v16.2.0/bin/node]
10: 0x7fff2057a621 start [/usr/lib/system/libdyld.dylib]
11: 0x5

Some other times, I got

/Users/hm/.nvm/versions/node/v16.2.0/bin/node[89516]: ../src/api/callback.cc:125:void node::InternalCallbackScope::Close(): Assertion `(env_->execution_async_id()) == (0)' failed.
 1: 0x10ebbf7e5 node::Abort() (.cold.1) [/Users/hm/.nvm/versions/node/v16.2.0/bin/node]
 2: 0x10d872b39 node::Abort() [/Users/hm/.nvm/versions/node/v16.2.0/bin/node]
 3: 0x10d8729a1 node::Assert(node::AssertionInfo const&) [/Users/hm/.nvm/versions/node/v16.2.0/bin/node]
 4: 0x10d7a2cdd node::InternalCallbackScope::Close() [/Users/hm/.nvm/versions/node/v16.2.0/bin/node]
 5: 0x10d7a25de node::InternalCallbackScope::~InternalCallbackScope() [/Users/hm/.nvm/versions/node/v16.2.0/bin/node]
 6: 0x10d813b88 node::Environment::RunTimers(uv_timer_s*) [/Users/hm/.nvm/versions/node/v16.2.0/bin/node]
 7: 0x10e267877 uv__run_timers [/Users/hm/.nvm/versions/node/v16.2.0/bin/node]
 8: 0x10e26c0ad uv_run [/Users/hm/.nvm/versions/node/v16.2.0/bin/node]
 9: 0x10d7a3ea4 node::SpinEventLoop(node::Environment*) [/Users/hm/.nvm/versions/node/v16.2.0/bin/node]
10: 0x10d8b4414 node::NodeMainInstance::Run(node::EnvSerializeInfo const*) [/Users/hm/.nvm/versions/node/v16.2.0/bin/node]
11: 0x10d84097d node::Start(int, char**) [/Users/hm/.nvm/versions/node/v16.2.0/bin/node]
12: 0x7fff2057a621 start [/usr/lib/system/libdyld.dylib]
13: 0x7

Additional information

It only happens in Node.js since 16.2.0.
@kamilogorek provided some useful info at
getsentry/sentry-javascript#3585 (comment)
@Hongbo-Miao Hongbo-Miao changed the title [Node.js 16] void node::InternalCallbackScope::Close(): Assertion `(env_->execution_async_id()) == (0)' failed Error: async hook stack has become corrupted (actual: 73, expected: 0) May 27, 2021
@Hongbo-Miao Hongbo-Miao reopened this May 27, 2021
This was referenced May 27, 2021
Closed
Closed
@Ayase-252
Copy link
Member

@Ayase-252 Ayase-252 commented May 27, 2021

Would you provide a minimal repro without third-party module? It could be great helpful.
@Hongbo-Miao
Copy link
Author

@Hongbo-Miao Hongbo-Miao commented May 27, 2021 •
edited

Hmm, this is already a quite minimal repo. It needs Sentry and OpenTelemetry together to trigger the error.
(The original repo is way larger)
@kamilogorek
Copy link

@kamilogorek kamilogorek commented May 27, 2021

After doing some digging, the exact place where it triggers an exception in opentelemetry code - https://github.com/open-telemetry/opentelemetry-js/blob/7fa4ff70d1aad5875cb14c6bff99c838228447bb/packages/opentelemetry-tracing/src/MultiSpanProcessor.ts#L58
@Ayase-252
Copy link
Member

@Ayase-252 Ayase-252 commented May 28, 2021

Reproduciable in master
@bl-ue bl-ue mentioned this issue May 31, 2021
Open
Qard added a commit to Qard/node that referenced this issue Jun 3, 2021
@Qard
async_hooks: switch between native and context hooks correctly
2a20c6b 
🤦 Might help if I remember to disable the _other_ promise
hook implementation when switching between them...

Fixes nodejs#38814
Fixes nodejs#38815
@Qard Qard mentioned this issue Jun 3, 2021
Closed
Qard added a commit to Qard/node that referenced this issue Jun 3, 2021
@Qard
async_hooks: switch between native and context hooks correctly
f44fce9 
🤦 Might help if I remember to disable the _other_ promise
hook implementation when switching between them...

Fixes nodejs#38814
Fixes nodejs#38815
Qard added a commit to Qard/node that referenced this issue Jun 3, 2021
@Qard
async_hooks: switch between native and context hooks correctly
a86542e 
🤦 Might help if I remember to disable the _other_ promise
hook implementation when switching between them...

Fixes nodejs#38814
Fixes nodejs#38815
Qard added a commit to Qard/node that referenced this issue Jun 3, 2021
@Qard
async_hooks: switch between native and context hooks correctly
9a2461e 
🤦 Might help if I remember to disable the _other_ promise
hook implementation when switching between them...

Fixes nodejs#38814
Fixes nodejs#38815
Qard added a commit to Qard/node that referenced this issue Jun 3, 2021
@Qard
async_hooks: switch between native and context hooks correctly
9fbf850 
🤦 Might help if I remember to disable the _other_ promise
hook implementation when switching between them...

Fixes nodejs#38814
Fixes nodejs#38815
Qard added a commit to Qard/node that referenced this issue Jun 3, 2021
@Qard
async_hooks: switch between native and context hooks correctly
a2cf4b3 
🤦 Might help if I remember to disable the _other_ promise
hook implementation when switching between them...

Fixes nodejs#38814
Fixes nodejs#38815
@Flarna Flarna closed this in 1c36eef Jun 5, 2021
@Qard
Copy link
Member

@Qard Qard commented Jun 6, 2021

This should be fixed by #38912 which will be in the next release, likely 16.3.1 or 16.4.0. If you have any further issues, let me know!
targos added a commit that referenced this issue Jun 11, 2021
@Qard @targos
async_hooks: switch between native and context hooks correctly
Verified
This commit was signed with the committer’s verified signature.
targos Michaël Zasso
GPG key ID: 770F7A9A5AE15600 Learn about vigilant mode.
03e75fd 
🤦 Might help if I remember to disable the _other_ promise
hook implementation when switching between them...

Fixes #38814
Fixes #38815
Refs #36394

PR-URL: #38912
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Bryan English <bryan@bryanenglish.com>
Qard added a commit to Qard/node that referenced this issue Jun 15, 2021
@Qard
async_hooks: switch between native and context hooks correctly
daa2e0c 
🤦 Might help if I remember to disable the _other_ promise
hook implementation when switching between them...

Fixes nodejs#38814
Fixes nodejs#38815
Refs nodejs#36394

PR-URL: nodejs#38912
Reviewed-By: Vladimir de Turckheim <vlad2t@hotmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Bryan English <bryan@bryanenglish.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
async_hooks
Projects
None yet
Milestone
No milestone
Linked pull requests

Successfully merging a pull request may close this issue.

async_hooks: switch between native and context hooks correctly
4 participants
@Qard @kamilogorek @Hongbo-Miao @Ayase-252