fix(cdk/testing): strongly type return value of TestElement.getProperty #22918
Conversation
crisbeto
added
P3
google-cla
bot
added
the
cla: yes
| @@ -206,8 +206,8 @@ export class ProtractorElement implements TestElement { | |||
| } | |||
|
|
|||
| /** Gets the value of a property of an element. */ | |||
| async getProperty(name: string): Promise<any> { | |||
| return browser.executeScript(`return arguments[0][arguments[1]]`, this.element, name); | |||
| async getProperty<T = any>(name: string): Promise<T> { | |||
There was a problem hiding this comment.
ideally we'd make the default unknown but I guess maybe that's too breaking?
There was a problem hiding this comment.
Yeah, I suspect that unknown will be breaking. I doubt that getProperty is used too often since most of the time you can get the same information through getAttribute.
crisbeto
added
the
merge ready
LGTM. Agreed on unknown being better in the future; we could have a migration for that.
| async getProperty(name: string): Promise<any> { | ||
| return browser.executeScript(`return arguments[0][arguments[1]]`, this.element, name); | ||
| async getProperty<T = any>(name: string): Promise<T> { | ||
| return browser.executeScript<T>(`return arguments[0][arguments[1]]`, this.element, name); |
There was a problem hiding this comment.
it seems that google's internal typings do not support a generic version of executeScript can you change this to return browser.executeScript(...) as any
mmalerba
removed
the
merge ready
Allows for the return value of `TestElement.getProperty` to be typed strongly through a generic parameter.
|
Done. Also rebased. |
crisbeto
added
the
merge ready
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Allows for the return value of
TestElement.getPropertyto be typed strongly through a generic parameter.