Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fast-track npm PRs and dont-land them on LTS #38885

Closed
wants to merge 1 commit into from

Conversation

@targos
Copy link
Member

@targos targos commented Jun 1, 2021

@nodejs/npm

@github-actions github-actions bot added the meta label Jun 1, 2021
@bl-ue
bl-ue approved these changes Jun 1, 2021
@richardlau
Copy link
Member

@richardlau richardlau commented Jun 1, 2021

fast-track npm PRs

Was the intent to add the fast-track label?

@targos
Copy link
Member Author

@targos targos commented Jun 1, 2021

fast-track npm PRs

Was the intent to add the fast-track label?

Yes 😅

Copy link
Member

@ruyadorno ruyadorno left a comment

❤️

@@ -78,6 +78,7 @@ subSystemLabels:
/^deps\/v8\/tools\/gen-postmortem-metadata\.py/: V8 Engine, post-mortem
/^deps\/v8\//: V8 Engine
/^deps\/uvwasi\//: wasi
/^deps\/npm\//: npm, fast-track, dont-land-on-v14.x, dont-land-on-v12.x

This comment has been minimized.

@jasnell

jasnell Jun 1, 2021
Member

I'm generally -1 on automatically marking dependency PRs as fast-track.

This comment has been minimized.

@targos

targos Jun 1, 2021
Author Member

I'd like to defer to @ruyadorno or someone else from the npm team. I added it because all recent npm PRs were fast-tracked.

This comment has been minimized.

@MylesBorins

MylesBorins Jun 1, 2021
Member

We always fast-track every npm update. We had previously asked about maybe carving out something in the process to allow us to land stuff without a fast track.

Pragmatically... the npm team will always ask for a fast-track on every dep update... and with the update now being automated we will always have at least 2 collaborators to approve the fast-track on hand.

Following the process to be consistent makes sense, but perhaps it is worth again revising the approval process for dependencies that we as a project vendor (and hopefully automate the vendoring)

This comment has been minimized.

@ruyadorno

ruyadorno Jun 1, 2021
Member

thanks @targos! as @MylesBorins contextualized already, in practice we have been always asking for a fast-track on every npm update PR and it would be appreciated to just automate that manual work that is already there today.

That said, another challenge we have currently is that not all people in the @nodejs/npm team seem to have access to add/remove labels in the Node.js repo, so alternatively if we're not landing this change here I would like to see an alternative to make that workflow improved for the rest of the team.

This comment has been minimized.

@darcyclarke

darcyclarke Jun 1, 2021
Member

+1 on @ruyadorno's comments/suggestions - personally prefer that automated label route though

This comment has been minimized.

@jasnell

jasnell Jun 1, 2021
Member

I won't block if that's what is consistent.

This comment has been minimized.

@ruyadorno

ruyadorno Jun 1, 2021
Member

thanks @jasnell 😄

This comment has been minimized.

@MylesBorins

MylesBorins Jun 1, 2021
Member

@jasnell there is the alternative of not requiring the fast-track to land an npm update with 2 reviews 😉

@gengjiawen
Copy link
Member

@gengjiawen gengjiawen commented Jun 3, 2021

@targos This needs rebase.

@targos targos force-pushed the targos:label-pr-npm branch from 5f7ef95 to 51bd1e5 Jun 3, 2021
@targos
Copy link
Member Author

@targos targos commented Jun 4, 2021

Landed in 6fe89a1

@targos targos closed this Jun 4, 2021
@targos targos deleted the targos:label-pr-npm branch Jun 4, 2021
targos added a commit that referenced this pull request Jun 4, 2021
PR-URL: #38885
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ruy Adorno <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
targos added a commit that referenced this pull request Jun 11, 2021
PR-URL: #38885
Reviewed-By: Richard Lau <[email protected]>
Reviewed-By: Ruy Adorno <[email protected]>
Reviewed-By: Jiawen Geng <[email protected]>
@danielleadams danielleadams mentioned this pull request Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

8 participants