Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a failing test for Suspense hydration #21630

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

@gaearon
Copy link
Member

@gaearon gaearon commented Jun 5, 2021

This shows a bug in hydration where server content is incorrectly being deleted and warned about.

Quoting @sebmarkbage on the cause:

So it happens because React doesn't stop rendering siblings when something suspends. Hydration or otherwise.

So when the sibling suspends, we see that ok we can't commit this. But let's see what happens next. But we don't know how many DOM nodes to skip over because the thing that suspended could render zero or many DOM nodes. So the hydration pointer is left where it was.

I think there was also some related bug with Fragments but I don't know what the repro is.

@sizebot
Copy link

@sizebot sizebot commented Jun 5, 2021

Comparing: 23c8095...6e928c8

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.min.js = 127.29 kB 127.29 kB = 40.81 kB 40.81 kB
oss-experimental/react-dom/cjs/react-dom.production.min.js = 130.11 kB 130.11 kB = 41.75 kB 41.75 kB
facebook-www/ReactDOM-prod.classic.js = 404.72 kB 404.72 kB = 74.90 kB 74.90 kB
facebook-www/ReactDOM-prod.modern.js = 393.27 kB 393.27 kB = 73.09 kB 73.09 kB
facebook-www/ReactDOMForked-prod.classic.js = 404.72 kB 404.72 kB = 74.90 kB 74.90 kB

Significant size changes

Includes any change greater than 0.2%:

(No significant changes)

Generated by 🚫 dangerJS against 6e928c8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants