Next/experimental release versions include commit date #21700
Conversation
bvaughn
changed the title
|
Comparing: d7dce57...68053d9 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: (No significant changes) |
bvaughn
changed the title
|
Seems unfortunate that our version number logic is split between "scripts/release" and "scripts/rollup". |
|
Not totally opposed, but let's discuss at next team meeting before merging |
|
If we do decide to merge this, I would put the date at the end of the string instead of the middle so that it can't be matched by a ^ or ~. |
|
Actually it seems like there's enough consensus on the team that if you put the date at the end, we can go ahead and merge it |
|
Let's be sure to update any references on the website to the new formatting, e.g. https://reactjs.org/docs/release-channels.html#experimental-channel |
|
And the workgroup post: reactwg/react-18#9 |
|
Weird. The CI failure looks like it's from the previous version of the build file. It doesn't have the changes I pushed. Hmm.
I'll try pushing again. |
bvaughn
force-pushed the
bvaughn:next-experimental-release-versions
branch
from
f0776fd
to
ab7e1e7
Change format of @next and @experimental release versions from <number>-<sha> to <number>-<sha>-<date> to make them more human readable.
bvaughn
force-pushed the
bvaughn:next-experimental-release-versions
branch
from
b30372a
to
68053d9
bvaughn
merged commit 355591a
into
facebook:master
To account for changes made in PR facebook/react/pull/21700
To account for changes made in PR facebook/react/pull/21700
Change format of @next and @experimental release versions from
<number>-<sha>to<number>-<sha>-<date>to make them more human readable. This format still preserves the ability for us to easily map a version number to the changes it contains, while also being able to more easily know at a glance how recent a release is.Note that the date used is the date of the commit (not the current date).
scripts/release/build-release-locally.js) and verify version number in packages contains the date of the commit (e.g.0.0.0-68053d940-20210623) and the version embedded as theReactVersionconst does as well (e.g.17.0.3-68053d940-20210623).scripts/release/prepare-release-from-ci.js) and verify version number in packages contains the date of the commit (0.0.0-68053d940-20210623or0.0.0-experimental-68053d940-20210623).