This repository was archived by the owner on Aug 29, 2024. It is now read-only.
[WIP] Modularized version of the multicast RPCs#3173
Closed
ImprobableNic wants to merge 2 commits intomasterfrom
Closed
[WIP] Modularized version of the multicast RPCs#3173ImprobableNic wants to merge 2 commits intomasterfrom
ImprobableNic wants to merge 2 commits intomasterfrom
Conversation
|
Corresponding JIRA ticket: https://improbableio.atlassian.net/browse/UNR-5038 |
improbable-prow-robot
added
do-not-merge/work-in-progress
ImprobableNic
force-pushed
the
feature/UNR-5038-modularized-multicast-RPC
branch
from
2a688e5 to
b76ce92
Compare
improbable-prow-robot
added
size/XXL
mironec
reviewed
Oct 17, 2021
| TimestampAndETWrapper<FRPCPayload>(RPCName, Serializer.GetComponentId(), EventTracer)); | ||
|
|
||
| RPCService::RPCReceiverDescription Desc; | ||
| Desc.Authority = 0; |
Contributor
There was a problem hiding this comment.
What does the 0 mean here? I am probably just lacking context.
Contributor
There was a problem hiding this comment.
Suggested change
| Desc.Authority = 0; | |
| Desc.Authority = NoAuthorityNeeded; |
| { | ||
| ClientServerRPCs.AdvanceView(); | ||
| MulticastRPCs.AdvanceView(); | ||
| // ClientServerRPCs.AdvanceView(); |
| TestEqual(TEXT("Test right entity has received"), Entity, EntityForTest); | ||
| TestTrue(TEXT("Received a valid RPC"), Data.ValidRPC); | ||
| TestEqual(TEXT("Read RPC in the expected order"), Data.Identifier, ExpectedRpcId); | ||
| //++ExpectedRpcId; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Modularized version of the multicast RPC
Tests
TODO Should write a test for UNR-5480