This repository was archived by the owner on Aug 29, 2024. It is now read-only.
Created a separate type for EntityIds and utilized it#3189
Closed
improbable-dmitrii wants to merge 1 commit intomasterfrom
Closed
Created a separate type for EntityIds and utilized it#3189improbable-dmitrii wants to merge 1 commit intomasterfrom
improbable-dmitrii wants to merge 1 commit intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Describe your changes here.
Release note
REQUIRED: Add a release note to the
##Unreleasedsection of CHANGELOG.md. You can find guidance for writing useful release notes here. Documentation changes are exempt from this requirement.Tests
How did you test these changes prior to submitting this pull request?
What automated tests are included in this PR?
STRONGLY SUGGESTED: How can this be verified by QA?
Documentation
How is this documented (for example: release note, upgrade guide, feature page, in-code documentation)?
Reminders (IMPORTANT)
If your change relies on a breaking engine change:
SPATIAL_ENGINE_VERSIONinEngine\Source\Runtime\Launch\Resources\SpatialVersion.h(in the engine fork) as well asSPATIAL_GDK_VERSIONinSpatialGDK\Source\SpatialGDK\Public\Utils\EngineVersionCheck.h. This helps others by providing a more helpful message during compilation to make sure the GDK and the Engine are up to date.If your change updates
Setup.bat,Setup.sh, core SDK version, any C# tools inSpatialGDK\Build\Programs\Improbable.Unreal.Scripts, or hand-written schema inSpatialGDK\Extras\schema:RequireSetup. This will automatically runSetup.batorSetup.shwhen the GDK is next pulled.Primary reviewers
If your change will take a long time to review, you can name at most two primary reviewers who are ultimately responsible for reviewing this request. @ mention them.