Skip to content
This repository was archived by the owner on Aug 29, 2024. It is now read-only.

Created a separate type for EntityIds and utilized it#3189

Closed
improbable-dmitrii wants to merge 1 commit intomasterfrom
temp/entity-id-separate-type
Closed

Created a separate type for EntityIds and utilized it#3189
improbable-dmitrii wants to merge 1 commit intomasterfrom
temp/entity-id-separate-type

Conversation

@improbable-dmitrii
Copy link

Description

Describe your changes here.

Release note

REQUIRED: Add a release note to the ##Unreleased section of CHANGELOG.md. You can find guidance for writing useful release notes here. Documentation changes are exempt from this requirement.

Tests

How did you test these changes prior to submitting this pull request?
What automated tests are included in this PR?

STRONGLY SUGGESTED: How can this be verified by QA?

Documentation

How is this documented (for example: release note, upgrade guide, feature page, in-code documentation)?

Reminders (IMPORTANT)

If your change relies on a breaking engine change:

  • Increment SPATIAL_ENGINE_VERSION in Engine\Source\Runtime\Launch\Resources\SpatialVersion.h (in the engine fork) as well as SPATIAL_GDK_VERSION in SpatialGDK\Source\SpatialGDK\Public\Utils\EngineVersionCheck.h. This helps others by providing a more helpful message during compilation to make sure the GDK and the Engine are up to date.

If your change updates Setup.bat, Setup.sh, core SDK version, any C# tools in SpatialGDK\Build\Programs\Improbable.Unreal.Scripts, or hand-written schema in SpatialGDK\Extras\schema:

  • Increment the number in RequireSetup. This will automatically run Setup.bat or Setup.sh when the GDK is next pulled.

Primary reviewers

If your change will take a long time to review, you can name at most two primary reviewers who are ultimately responsible for reviewing this request. @ mention them.

@improbable-prow-robot improbable-prow-robot added jira/no-ticket Indicates a PR has no corresponding JIRA ticket do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/XXL Denotes a PR that changes 600+ lines, ignoring generated files. labels Jun 16, 2021
@m-samiec m-samiec closed this Jan 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. jira/no-ticket Indicates a PR has no corresponding JIRA ticket size/XXL Denotes a PR that changes 600+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants