Should the input update be done before the script update?

[yaustar]

https://github.com/playcanvas/engine/blob/master/src/framework/application.js#L1149

At the moment, the input update is done after script update which means that input can be a frame behind?

[mvaligursky]

it should be done before, agreed.

[willeastcott]

I agree too - it looks wrong, currently. Well spotted.

[mvaligursky]

Reopening due to this change causing issues, see the comments in #3216
More complex fix is needed.

[yaustar]

The keyboard and mouse update functions don't actually poll the current state of both devices but instead, copy the current state of buttons to the the last frame data and therefore needs to be called after script updates unless we change how it works.

eg https://github.com/playcanvas/engine/blob/master/src/input/keyboard.js#L260

The gamepad update is different and actually does poll the current state of gamepads from the browser so needs to be called before the script update or be a frame behind.