Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Devfile registry: it is not clear in which order to execute commands in some devfiles #19458

Open
1 of 23 tasks
sunix opened this issue Mar 30, 2021 · 4 comments
Open
1 of 23 tasks

Comments

@sunix
Copy link
Contributor

@sunix sunix commented Mar 30, 2021

Describe the bug

Some devfiles have several commands that need to be executed in a precise order to succeed.
Some are named with prefixed numbers that help the user, but some others are not.

For instance:

  • angular
  • python-django

Che version

  • latest
  • nightly
  • other: please specify

Steps to reproduce

  1. start the Django Python devfile
  2. open my workspace view
  3. start the first command: install dependencies
  4. it fails sh: 1: .: Can't open /projects/.venv/bin/activate

Expected behavior

the commands should be prefixed with numbers that would tell which one to start. in this case, user should execute the command set up venv first, but it is listed in alphabetical order: at the end.

Runtime

  • kubernetes (include output of kubectl version)
  • Openshift (include output of oc version)
  • minikube (include output of minikube version and kubectl version)
  • minishift (include output of minishift version and oc version)
  • docker-desktop + K8S (include output of docker version and kubectl version)
  • other: (please specify)

Screenshots

Selection_301

Installation method

  • chectl
    • provide a full command that was used to deploy Eclipse Che (including the output)
    • provide an output of chectl version command
  • OperatorHub
  • I don't know

Environment

  • my computer
    • Windows
    • Linux
    • macOS
  • Cloud
    • Amazon
    • Azure
    • GCE
    • other (please specify)
  • Dev Sandbox (workspaces.openshift.com)
  • other: please specify

Eclipse Che Logs

Additional context

@l0rd
Copy link
Contributor

@l0rd l0rd commented Mar 31, 2021

The numbers are a workaround but the right solution is to run the prerequisite commands if they haven't been run before.

@l0rd
Copy link
Contributor

@l0rd l0rd commented Mar 31, 2021

Also it would be nice to see the list of examples that have this problem in this issue. We could make it an epic. Adding n&n label anyway as that has a important impact on UX, especially for new users.

@sunix
Copy link
Contributor Author

@sunix sunix commented Mar 31, 2021

The numbers are a workaround but the right solution is to run the prerequisite commands if they haven't been run before.

Could this be part of devfile v2?

@l0rd
Copy link
Contributor

@l0rd l0rd commented Mar 31, 2021

Could this be part of devfile v2?

v2 has composite commands. I don't think it will solve the problem though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants