ericholscher
Follow
Pinned
2,923 contributions in the last year
Less
More
Contribution activity
June 2021
Created 1 repository
Created a pull request in readthedocs/readthedocs.org that received 27 comments
Don't do any CORS checking on Embed API requests
This allows users to embed site content from any domain, which is a common use case for the Embed API. I looked, and it seems most of the URL's in …
+34
−3
•
27
comments
Opened 12 other pull requests in 3 repositories
readthedocs/ethical-ad-server
2
open
4
merged
readthedocs/readthedocs.org
5
merged
readthedocs/ethicalads.io
1
merged
Reviewed 44 pull requests in 8 repositories
readthedocs/readthedocs.org 24 pull requests
- Docs: document how to terminate a session
- Add new guide about Jupyter in Sphinx
- Add tests for remove index files
- Allow to change the privacy level of external versions
- Search: remove additional fields
- QuerySets: remove include_all
- Design doc: Embed APIv3
- Add proposal for new Sphinx and RTD tutorials
- Hit Elasticsearch only once for each search query through the APIv2
- Search: small improvements
- Search: ask for confirmation when running reindex_elasticsearch
- Search: allow to filter by project slugs
- Search: remove workaround for subprojects
- Builds: check for nonexistent object
- Add basic security policy
- Footer: return well formed html
- Make sustainability page more visible
- Search: use multi-fields for Wildcard queries
- Docs: embed API
- Don't do any CORS checking on Embed API requests
- Backport manual indexes
- Add project/build filters
- Add ability to rebuild a specific build
- Cache get_project
readthedocs/ethical-ad-server 7 pull requests
readthedocs/ethicalads.io 6 pull requests
writethedocs/www 2 pull requests
readthedocs/blog 2 pull requests
sphinx-doc/sphinx 1 pull request
readthedocs/readthedocs-docker-images 1 pull request
readthedocs/sphinx-hoverxref 1 pull request
Created an issue in readthedocs/ethical-ad-client that received 1 comment
No alt on the ad image
Got this report from a publisher: I have a quick request: the images that EthicalAds injects do not have an alt attribute and this is an accessibi…
1
comment
Opened 2 other issues in 1 repository
readthedocs/readthedocs.org
2
open
43
contributions
in private repositories
Jun 1 – Jun 25