feat(picker-column): add 'showName' property#23576
feat(picker-column): add 'showName' property#23576Giulio-91 wants to merge 1 commit intoionic-team:mainfrom
Conversation
add the possibility tho display the column name by setting the showName column property to true
|
Thanks for the PR! Is there an associated issue for this PR? |
No. Should I create it? |
|
If there isn't one already that's fine. Could you please explain the use case for this feature? |
Yes of course. I needed to show the column name of the picker. So I added the "showName" property in the 'PickerColumn' interface. If it is set to true, the column name is shown on the top of the column. I also added an example in the test script. |
|
Thanks for the clarification and apologies for the delay. What is the benefit of showing the column name instead of using I think the addition of this API is a bit confusing since it lets you describe the column in two different ways. Here is a screenshot of the example you added: The "hours" suffix describes the column, so having |
|
Thanks for the PR! I discussed this with the team and we are unable to accept your PR at this time. We feel that the existing As I mentioned in #23576 (comment), native iOS apps use the suffix and prefix features to assign labels to picker columns. Adding the In the future we recommend opening an issue first before creating a PR as it lets us discuss the scope of a feature before any programming work begins. Please let me know if you have any questions. Thank you! |

add the possibility tho display the column name by setting the showName column property to true
Pull request checklist
Please check if your PR fulfills the following requirements:
npm run build) was run locally and any changes were pushednpm run lint) has passed locally and any fixes were made for failuresPull request type
Please check the type of change your PR introduces:
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this introduce a breaking change?
Other information