Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: #1883 Add TypeScript #1900

Open
wants to merge 1 commit into
base: master
from
Open

Conversation

@arantespp
Copy link

@arantespp arantespp commented Apr 13, 2020

Tasks:

  • create a TypeScript first configuration
  • create tsbuild npm script
  • create the file bits/04_base64.ts

With this PR, I proposed to create the file bits/04_base64.ts and the corresponding .js is generated running the command npm run tsbuild, which will create bits/04_base64.js file.

I've kept the original tsconfig.json file to be easier to adjust if we want to. When the final configuration arrives, we delete all commented properties.

@arantespp
Copy link
Author

@arantespp arantespp commented Apr 13, 2020

@arantespp arantespp changed the title fix: #1883 fix: #1883 Add typescript Apr 13, 2020
@arantespp arantespp changed the title fix: #1883 Add typescript fix: #1883 Add TypeScript Apr 13, 2020
@SheetJSDev SheetJSDev force-pushed the SheetJS:master branch from 0786b99 to 3b589f0 Aug 12, 2020
@SheetJSDev SheetJSDev force-pushed the SheetJS:master branch from 4254ed4 to eec93b0 Oct 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.