Added Documentaion for issue #2139#2210
Closed
himanshusaini111 wants to merge 1 commit intoSheetJS:masterfrom
Closed
Added Documentaion for issue #2139#2210himanshusaini111 wants to merge 1 commit intoSheetJS:masterfrom
himanshusaini111 wants to merge 1 commit intoSheetJS:masterfrom
Conversation
Contributor
|
Blurb should be moved below the table. See https://github.com/SheetJS/sheetjs/blob/master/README.md#parsing-options as an example of how the notes should be laid out ( @paustint thoughts? |
Contributor
Author
Thanks for the feedback. Update: I have updated this PR please check @SheetJSDev @paustint |
moved the note below the table
himanshusaini111
force-pushed
the
added_doc_for_mutated_header
branch
from
34a1bcd to
09396c0
Compare
SheetJSDev
force-pushed
the
master
branch
2 times, most recently
from
7d51b80 to
1d7aff4
Compare
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: #2139
Added Documentation to specify the mutable nature of headers passed and why it's intended and actually useful.