Skip to content

/ egg Public

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add application level Cookie options #4086

Merged
merged 2 commits into from Dec 7, 2019
Merged

feat: add application level Cookie options #4086

merged 2 commits into from Dec 7, 2019

Conversation

@fengmk2
Copy link
Member

@fengmk2 fengmk2 commented Dec 6, 2019

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change
@fengmk2 fengmk2 requested review from popomore and dead-horse Dec 6, 2019
@fengmk2
Copy link
Member Author

@fengmk2 fengmk2 commented Dec 6, 2019

https://www.ruanyifeng.com/blog/2019/09/cookie-samesite.html

@fengmk2
Copy link
Member Author

@fengmk2 fengmk2 commented Dec 6, 2019

image

@fengmk2
Copy link
Member Author

@fengmk2 fengmk2 commented Dec 6, 2019

解决大量警告提示

image

@codecov
Copy link

@codecov codecov bot commented Dec 7, 2019 •
edited

Codecov Report

Merging #4086 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #4086   +/-   ##
======================================
  Coverage     100%    100%           
======================================
  Files          34      34           
  Lines         954     954           
======================================
  Hits          954     954
Impacted Files Coverage Δ
config/config.default.js 100% <ø> (ø) ⬆️
app/extend/context.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7718c1...bcec85e. Read the comment docs.

fengmk2 added 2 commits Dec 7, 2019
@fengmk2
feat: add application level Cookie options
13d76fb
@fengmk2
test: fix doctools path on windows
bcec85e
@fengmk2 fengmk2 force-pushed the add-application-level-cookie-options branch from 998779c to bcec85e Dec 7, 2019
@fengmk2 fengmk2 merged commit b28134e into master Dec 7, 2019
12 of 16 checks passed
@fengmk2 fengmk2 deleted the add-application-level-cookie-options branch Dec 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@popomore popomore

@dead-horse dead-horse

Assignees

@atian25 atian25

@dead-horse dead-horse

Labels
core: cookie deps: egg-cookies
Projects
None yet
Milestone
No milestone
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
@fengmk2 @atian25 @dead-horse