Add types to refs #1295
Merged
Add types to refs #1295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tidy up testing section
Add paragraph space
|
Tremendous work, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Adding types to refs module, and backtracking to make sure they agree with previous types.
I also changed the hard-coding of Traversable.list_traverse(on_edge= True) that I put in last time to be a check for it in kwargs. At the moment all it does is raise an additional deprecation warning if anyone tried to use on_edge= True - I don't think anyone would be, but better than breaking it without warning.
Also made Traversable, Serilizable and IterableObj into Protocols (typings version of abstract base classes) - shouldnt have any effect on users unless they are doing something wierd.
Added flake8-bugbear and flake8-comprehensions and fixed the (minor) complaints they had.
Removed some checks for python 3.5 in tests.