jonahwilliams
Follow
jonahwilliams
Follow
Pinned
3,212 contributions in the last year
Less
More
Activity overview
Contribution activity
July 2021
Created 10 commits in 1 repository
Created a pull request in flutter/flutter that received 36 comments
[flutter] prevent errant text field clicks from losing focus
Without making dramatic adjustments to the focus system, attempts to support the text field / editable text nesting while still preventing clicks f…
+135
−35
•
36
comments
Opened 11 other pull requests in 2 repositories
flutter/flutter
8
merged
2
open
- [flutter] remove elevation checker
- text selection for the web
- [flutter_tools] support trailing args
- Revert "[flutter_tools] let the logger know about machine mode"
- [flutter_tools] fix -n workaround
- [flutter] tab navigation does not notify the focus scope node
- [flutter_tools] add preHotRestart callbacks
- [flutter_tools] let the logger know about machine mode
- [flutter_tools] revert change to SETLOCAL ENABLEDELAYEDEXPANSION
- Update devtools_launcher.dart comment
flutter/engine
1
open
Reviewed 41 pull requests in 3 repositories
flutter/flutter 39 pull requests
- Remove AndroidX compatibility workarounds
- Remove obsolete codegen_integration tests
- [flutter_tools] add a JsonHelper class for easier json processing
- Make the startup lock message print to stderr.
-
[flutter_tools] Improve toolexit error messages for
flutter upgrade - Handle reserved Kotlin keywords
- Update args package
- Skip "newly added code executes during hot restart - canvaskit"
- Update dwds (and other packages)
- Remove unused web_incremental_test
- Remove unused flutter_run_test
- Remove obsolete plugin_test_win
- Remove unused tiles_scroll_perf_iphonexs__timeline_summary
- Remove unused build_mode_test
- [gen_l10n] support 'select'
- Reland [flutter_tools] show only supported sub commands
- [flutter_tools] Refactor Android Studio Detection on Windows (support 4.x and 202x releases detection)
- text selection for the web
- Disable the automatic "pub get" if the project is using a third-party tool for linking dependencies.
- [flutter_tools] flutter update-packages --force upgrade
- Remove unnecessary variables.
- Rerun devicelab task from test runner
- [flutter_tools] support trailing args
- [web] use resident resident runner in flutter drive
- [flutter] prevent errant text field clicks from losing focus
- Some pull request reviews not shown.
flutter/engine 1 pull request
dart-lang/args 1 pull request
Created an issue in flutter/flutter that received 6 comments
Canvaskit binary needs to be cache-able by LUCI
While investigating a number of web integration test failures, I've found that these can be flaky because we sometimes fail to download canvaskit. …
6
comments
Opened 4 other issues in 1 repository
flutter/flutter
4
open
- Update Flutter Doctor windows checks to use ProcessManager.canRun
- Engine pre-commit hooks don't work on windows
- Building/running with a local profile/release engine should automatically select profile/release mode unless otherwise specified.
- Flutter Web/Dwds can lose print messages during a hot restart
1
contribution
in private repositories
Jul 7